From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 9A212221E5 for ; Thu, 25 Jan 2024 08:10:06 +0100 (CET) Received: (qmail 24372 invoked by uid 550); 25 Jan 2024 07:07:54 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 24338 invoked from network); 25 Jan 2024 07:07:54 -0000 From: Ismael Luceno To: musl@lists.openwall.com Cc: Rich Felker , Ismael Luceno Date: Thu, 25 Jan 2024 08:09:49 +0100 Message-ID: <20240125070950.28673-1-ismael@iodev.co.uk> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam: Yes Subject: [musl] [PATCH] fix avoidable segfault in catclose catclose may be called with an invalid argument, particularly -1 may be returned by catopen if there's an error. Signed-off-by: Ismael Luceno --- src/locale/catclose.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/locale/catclose.c b/src/locale/catclose.c index 54e24dd2163b..af959a58dfb5 100644 --- a/src/locale/catclose.c +++ b/src/locale/catclose.c @@ -8,6 +8,8 @@ int catclose (nl_catd catd) { + if (catd == (nl_catd)-1) + return -1; char *map = (char *)catd; munmap(map, V(map+8)+20); return 0; -- 2.43.0