From: Rich Felker <dalias@libc.org>
To: "Ignotas \"gns\" WANG" <infiwang@proton.me>
Cc: "musl@lists.openwall.com" <musl@lists.openwall.com>
Subject: Re: [musl] [PATCH] riscv: correct symbol version of __vdso_flush_icache
Date: Thu, 25 Jan 2024 14:10:25 -0500 [thread overview]
Message-ID: <20240125191025.GK4163@brightrain.aerifal.cx> (raw)
In-Reply-To: <20240125190533.GJ4163@brightrain.aerifal.cx>
On Thu, Jan 25, 2024 at 02:05:34PM -0500, Rich Felker wrote:
> On Thu, Jan 25, 2024 at 04:55:16PM +0000, Ignotas "gns" WANG wrote:
> > Hi,
> >
> > I'm porting LuaJIT to RISC-V, our binary built with musl would
> > occasionally SIGILL at patched JIT insns. It looks that musl's
> > __riscv_flush_icache is faulty, which may be the cause of this cache
> > coherency issue.
> >
> > For the patch, see the attachments.
> >
> > Since I'm not a subscriber to the musl list, CC me please.
>
> Just to be clear, this was always wrong, not a change on the kernel
> side where either symbol version might be seen depending on kernel
> version, right?
OK, answering my own question. The original Linux commit introducing
riscv vdso, e2c0cdfba7f69925afc92b20cd9835d81e11a4f1, has:
+VERSION
+{
+ LINUX_4.15 {
and 921ebd8f2c081b3cf6c3b29ef4103eef3ff26054 adds
__riscv_flush_icache under that. So apparently the version was just
miscopied/typo when added to musl.
I'll apply this right away and it'll be in the upcoming release.
Rich
prev parent reply other threads:[~2024-01-25 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 16:55 Ignotas "gns" WANG
2024-01-25 19:05 ` Rich Felker
2024-01-25 19:10 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125191025.GK4163@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=infiwang@proton.me \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).