From: Rich Felker <dalias@libc.org>
To: Andrew Cagney <andrew.cagney@gmail.com>
Cc: musl@lists.openwall.com
Subject: Re: [musl] glob(GLOB_BRACE)
Date: Thu, 1 Feb 2024 09:27:20 -0500 [thread overview]
Message-ID: <20240201142719.GV4163@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAJeAr6t-oy3BifUCoGJg+r6TRO9L3tkrAz0MActoz_z1NR3bDA@mail.gmail.com>
On Thu, Feb 01, 2024 at 08:48:01AM -0500, Andrew Cagney wrote:
> FYI, It's on the BSDs and glibc.
> Found by libreswan's test framework on alpine.
By the usual criteria, this one probably leans towards a no, at least
contingent on how constraining it is to support it.
If it happened at the fnmatch layer, it would very much be a no,
because that effectively imposes regex-equivalent (or at least very
close) matching algorithm complexity and is thereby impossible to do
efficiently in constant-space, vs the standard fnmatch language where
that is possible (and we do it).
For glob and GLOB_BRACE, it looks like it's "just" a matter of
iterating over the different expansions and applying glob to each, but
it seems to be underspecified how it interacts with escaping, special
chars, slashes, etc.
Do you have good reasons in favor of inclusion? My impression is that
everything that wants/needs it is shipping its own version of GNU glob
or whatever that has it, or else very little is using it; otherwise it
would have come up before. But if adding it allowed a lot of things to
drop GNU glob and just use the libc glob, that might be compelling.
Rich
next prev parent reply other threads:[~2024-02-01 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 13:48 Andrew Cagney
2024-02-01 14:27 ` Rich Felker [this message]
2024-02-01 15:53 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201142719.GV4163@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=andrew.cagney@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).