From: Rich Felker <dalias@libc.org>
To: Valery Ushakov <uwe@stderr.spb.ru>
Cc: musl@lists.openwall.com, toybox <toybox@lists.landley.net>
Subject: Re: [musl] Re: Not sure how to debug this one.
Date: Sun, 18 Feb 2024 09:33:13 -0500 [thread overview]
Message-ID: <20240218143312.GL4163@brightrain.aerifal.cx> (raw)
In-Reply-To: <ZdH-SF2_dzVR4hJe@snips.stderr.spb.ru>
[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]
On Sun, Feb 18, 2024 at 03:55:36PM +0300, Valery Ushakov wrote:
> On Sat, Feb 17, 2024 at 20:40:50 -0500, Rich Felker wrote:
>
> > due to incorrect base address register when attempting to reload the
> > saved value of r8, the caller's value of r8 was not preserved.
> > ---
> > src/signal/sh/sigsetjmp.s | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/signal/sh/sigsetjmp.s b/src/signal/sh/sigsetjmp.s
> > index 1e2270be..f0f604e2 100644
> > --- a/src/signal/sh/sigsetjmp.s
> > +++ b/src/signal/sh/sigsetjmp.s
> > @@ -27,7 +27,7 @@ __sigsetjmp:
> >
> > mov.l 3f, r0
> > 4: braf r0
> > - mov.l @(4+8,r4), r8
> > + mov.l @(4+8,r6), r8
> >
> > 9: mov.l 5f, r0
> > 6: braf r0
>
> That takes care of restoring caller's r8 for the first return from
> sigsetjmp, but isn't there still the problem that the jump buffer
> contains the wrong one, so on the second return from sigsetjmp the
> caller will have clobbered r8?
>
> Sorry for a drive-by reply. I'll try to take a closer look in the
> evening.
No, that's the return path for both returns.
The whole reason a call-saved register like r8 is used here is so that
we can return twice into the body of sigsetjmp, in order to tailcall
__sigsetjmp_tail at both the first return and subsequent return. This
is what makes it possible to restore the signal mask from the
returned-to frame rather than the returning-from frame (which is why
the attached doesn't crash with stack overflow on musl like it does on
glibc).
Rich
[-- Attachment #2: sigsetjmp_of.c --]
[-- Type: text/plain, Size: 260 bytes --]
#include <signal.h>
#include <setjmp.h>
static volatile long cnt = 1000000;
sigjmp_buf jb;
void handle(int s)
{
if (!cnt--) return;
raise(s);
siglongjmp(jb, 1);
}
int main()
{
if (sigsetjmp(jb, 1)) return 0;
signal(SIGALRM, handle);
raise(SIGALRM);
}
next prev parent reply other threads:[~2024-02-18 14:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 1:48 [musl] " Rob Landley
2024-02-17 3:23 ` [musl] Re: [Toybox] " Mouse
2024-02-17 13:32 ` Rob Landley
2024-02-17 15:01 ` [musl] " Thorsten Glaser
2024-02-17 15:21 ` [musl] " Mouse
2024-02-17 17:02 ` [musl] " Rich Felker
2024-02-17 21:45 ` [musl] " Valery Ushakov
2024-02-17 23:09 ` Thorsten Glaser
2024-02-18 12:15 ` [musl] " Valery Ushakov
2024-02-18 22:51 ` [musl] " Thorsten Glaser
2024-02-18 1:34 ` Rich Felker
2024-02-18 1:40 ` Rich Felker
2024-02-18 12:55 ` Valery Ushakov
2024-02-18 14:33 ` Rich Felker [this message]
2024-02-18 15:06 ` Valery Ushakov
2024-02-18 20:33 ` Rich Felker
2024-02-19 11:00 ` Valery Ushakov
2024-02-19 17:54 ` Rob Landley
2024-02-19 23:05 ` Rich Felker
2024-02-18 12:47 ` Valery Ushakov
2024-02-19 13:12 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240218143312.GL4163@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
--cc=toybox@lists.landley.net \
--cc=uwe@stderr.spb.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).