From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 64A2D2125B for ; Mon, 26 Feb 2024 02:25:05 +0100 (CET) Received: (qmail 6089 invoked by uid 550); 26 Feb 2024 01:21:32 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 6051 invoked from network); 26 Feb 2024 01:21:31 -0000 Date: Sun, 25 Feb 2024 20:25:09 -0500 From: Rich Felker To: Fangrui Song Cc: musl@lists.openwall.com Message-ID: <20240226012508.GC4163@brightrain.aerifal.cx> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] DT_PREINIT_ARRAY support On Sun, Jan 21, 2024 at 03:33:05PM -0800, Fangrui Song wrote: > There is a DT_PREINIT_ARRAY patch that falls through the cracks: > https://www.openwall.com/lists/musl/2016/05/17/2 > I wonder whether it can be visited again. I looked it over, and I think the latest version dropped the dummy definitions of __preinit_array_start/_end in dynlink.c. Accordig to the text in commit 19caa25d0a8e587bb89b79c3f629085548709dd4, I think they need to be added back. Otherwise it looks reasonable. So maybe with that change it can be merged? Rich