From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 753B629835 for ; Tue, 12 Mar 2024 01:46:36 +0100 (CET) Received: (qmail 9566 invoked by uid 550); 12 Mar 2024 00:42:25 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 9528 invoked from network); 12 Mar 2024 00:42:25 -0000 Date: Mon, 11 Mar 2024 20:46:42 -0400 From: Rich Felker To: Kate Deplaix Cc: "musl@lists.openwall.com" Message-ID: <20240312004641.GA4163@brightrain.aerifal.cx> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] Re: [PATCH] Increase NGROUPS_MAX from 32 to 1024 On Mon, Mar 11, 2024 at 06:31:13PM +0000, Kate Deplaix wrote: > Hi, > > Any chance this patch could be looked at? Thanks for the ping. I'll take a look and see if we can open a discussion on either doing something like this, or a more complete fix, in this release cycle. Rich > ________________________________ > From: Kate Deplaix > Sent: 14 November 2023 23:35 > To: musl@lists.openwall.com > Subject: [PATCH] Increase NGROUPS_MAX from 32 to 1024 > > Such a restrictive value for NGROUPS_MAX makes it impossible to have a musl-based system with a user belonging to more than 32 groups. If done on the root user, this will break your system. > It also makes it impossible to use certain functions in binaries that have been compiled with musl. > > This new value is still very far from Linux's NGROUPS_MAX of 65536 that has been there since Linux 2.6.4 but this is at least one tiny step in the right direction while maintainers investigate how to match Linux's value. > > ref: https://www.openwall.com/lists/musl/2021/07/03/1 > ref: https://www.openwall.com/lists/musl/2022/12/06/3 > ref: https://github.com/ocaml/opam/pull/5383 > --- > include/limits.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/limits.h b/include/limits.h > index 53a27b9d..501c3612 100644 > --- a/include/limits.h > +++ b/include/limits.h > @@ -45,7 +45,7 @@ > #define NAME_MAX 255 > #endif > #define PATH_MAX 4096 > -#define NGROUPS_MAX 32 > +#define NGROUPS_MAX 1024 > #define ARG_MAX 131072 > #define IOV_MAX 1024 > #define SYMLOOP_MAX 40 > -- > 2.40.1