From: Rich Felker <dalias@aerifal.cx>
To: Maks Mishin <maks.mishinfz@gmail.com>
Cc: musl@lists.openwall.com
Subject: [musl] Re: [PATCH] wcscat: Replace call of vulnerable function
Date: Sun, 24 Mar 2024 13:50:43 -0400 [thread overview]
Message-ID: <20240324175043.GC32430@brightrain.aerifal.cx> (raw)
In-Reply-To: <20240324172627.29640-1-maks.mishinFZ@gmail.com>
On Sun, Mar 24, 2024 at 08:26:27PM +0300, Maks Mishin wrote:
> Use of vulnerable function 'wcscpy' at wcscat.c:5.
> This function is unsafe, use wcsncpy instead.
>
> Found by RASU JSC.
>
> Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
> ---
> src/string/wcscat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/string/wcscat.c b/src/string/wcscat.c
> index d4f00ebd..b4e4b2eb 100644
> --- a/src/string/wcscat.c
> +++ b/src/string/wcscat.c
> @@ -2,6 +2,6 @@
>
> wchar_t *wcscat(wchar_t *restrict dest, const wchar_t *restrict src)
> {
> - wcscpy(dest + wcslen(dest), src);
> + wcsncpy(dest + wcslen(dest), src, sizeof dest);
> return dest;
> }
> --
> 2.30.2
Wrong for same reason as the sprintf one.
parent reply other threads:[~2024-03-24 17:50 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240324172627.29640-1-maks.mishinFZ@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240324175043.GC32430@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=maks.mishinfz@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).