From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 4FEC425790 for ; Sat, 27 Apr 2024 18:40:44 +0200 (CEST) Received: (qmail 29874 invoked by uid 550); 27 Apr 2024 16:40:38 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 29839 invoked from network); 27 Apr 2024 16:40:38 -0000 Date: Sat, 27 Apr 2024 12:40:50 -0400 From: Rich Felker To: lolzery wowzery Cc: musl@lists.openwall.com, Duncan Bellamy , info@bnoordhuis.nl, tony.ambardar@gmail.co Message-ID: <20240427164050.GA10433@brightrain.aerifal.cx> References: <20200119121247.37310-1-info@bnoordhuis.nl> <20220831190735.52016-1-dunk@denkimushi.com> <20220831190735.52016-2-dunk@denkimushi.com> <20240224165632.GA4163@brightrain.aerifal.cx> <20240424193038.GP4163@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] [PATCH 1/2] V3 resubmitting old statx patch with changes On Wed, Apr 24, 2024 at 07:55:32PM -0400, lolzery wowzery wrote: > Hi all! I'm new to git over email, new to musl, and I want to really > get into contributing to musl. So, I'd really appreciate any > tips/comments/info for a newbie like me! > > Please do not merge these changes yet. There's numerous problems with > this code above and beyond the issues you pointed out, and each of > those issues led me down successive rabbit holes all over the musl > source code and I've ended up opening a sizable can of worms, > including io race condition bugs in fallback conditions, symbol > weakness problems, header/struct misorganization, and bugs in syscall > support detection making musl silently/unexpectedly fail under certain > seccomp configurations. > > Also, let me cite the earlier patch from tony.ambardar@gmail.com about > renameat2. My patch will include a full proper renameat2 > implementation with validation and fallback and will compile on > systems where SYS_renameat2 is undefined (using exclusively the > fallback.) > > I recognize I probably sound like an over-eager-beaver fussing over > fools-gold as I'm new and none of you know me. (That's the assumption > I myself would make if a new guy showed up claiming to have lots of > bug fixes and stuff.) So, please suspend your disbelief for a short > while until I can give my full report and all fixes tomorrow for > everyone to review. Give me a chance to prove my commitment to musl > and watch as I uphold my pledge to maintain my areas of the code in > musl and keep them ship-shape. > > Have a great day everyone and really looking forwards to sharing my > full report tomorrow!, Ping. Any updates?