From: Rich Felker <dalias@libc.org>
To: lixing <lixing@loongson.cn>
Cc: musl@lists.openwall.com
Subject: Re: [musl] Add PAGESIZE definition for LoongArch
Date: Mon, 6 May 2024 08:36:24 -0400 [thread overview]
Message-ID: <20240506123624.GE10433@brightrain.aerifal.cx> (raw)
In-Reply-To: <dd0b7b09-f76c-5e78-1b10-8161a70c0e62@loongson.cn>
On Mon, May 06, 2024 at 05:05:36PM +0800, lixing wrote:
> Hi, Rich,
>
> arch/loongarch64/bits/limits.h | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 arch/loongarch64/bits/limits.h
>
> diff --git a/arch/loongarch64/bits/limits.h b/arch/loongarch64/bits/limits.h
> new file mode 100644
> index 00000000..5cd9aad6
> --- /dev/null
> +++ b/arch/loongarch64/bits/limits.h
> @@ -0,0 +1 @@
> +#define PAGESIZE 16384
Can you explain why you want this change? I would be very hesitant to
merge it. Defining PAGESIZE for an arch is a contract that the
application-facing runtime page size (i.e. mmap granularity) can
*never*, now or in the future, be anything other than the value you
define this macro as having.
Rich
next prev parent reply other threads:[~2024-05-06 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 9:05 lixing
2024-05-06 12:36 ` Rich Felker [this message]
2024-05-07 1:30 ` lixing
2024-05-07 1:39 ` Rich Felker
2024-05-07 1:45 ` lixing
2024-05-07 15:09 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506123624.GE10433@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=lixing@loongson.cn \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).