From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 4AD5121737 for ; Mon, 6 May 2024 14:36:17 +0200 (CEST) Received: (qmail 9421 invoked by uid 550); 6 May 2024 12:36:12 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 9376 invoked from network); 6 May 2024 12:36:11 -0000 Date: Mon, 6 May 2024 08:36:24 -0400 From: Rich Felker To: lixing Cc: musl@lists.openwall.com Message-ID: <20240506123624.GE10433@brightrain.aerifal.cx> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] Add PAGESIZE definition for LoongArch On Mon, May 06, 2024 at 05:05:36PM +0800, lixing wrote: > Hi, Rich, > >  arch/loongarch64/bits/limits.h | 1 + >  1 file changed, 1 insertion(+) >  create mode 100644 arch/loongarch64/bits/limits.h > > diff --git a/arch/loongarch64/bits/limits.h b/arch/loongarch64/bits/limits.h > new file mode 100644 > index 00000000..5cd9aad6 > --- /dev/null > +++ b/arch/loongarch64/bits/limits.h > @@ -0,0 +1 @@ > +#define PAGESIZE 16384 Can you explain why you want this change? I would be very hesitant to merge it. Defining PAGESIZE for an arch is a contract that the application-facing runtime page size (i.e. mmap granularity) can *never*, now or in the future, be anything other than the value you define this macro as having. Rich