[musl] alltype header typo in reg and user

[musl] alltype header typo in reg and user

[Gonzalo Alvarez]

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

First report here - forgive me if I'm missing something.

I'm using musl to build a cross toolchain for risc-v (specifically the
xuantie v0.7.1 vector c906v version). When using the headers to build the
packages in the buildroot, I hit an issue when including either sys/reg.h
or sys/user.h, since it looks like there was a recent change that added an
include there to bring 'alltypes.h' into those files, but the change is
missing the 's' at the end. The diff is more descriptive.

diff --git a/include/sys/reg.h b/include/sys/reg.h
index 4e6ce222..0272e137 100644
--- a/include/sys/reg.h
+++ b/include/sys/reg.h
@@ -4,7 +4,7 @@
 #include <limits.h>
 #include <unistd.h>

-#include <bits/alltype.h>
+#include <bits/alltypes.h>

 #undef __WORDSIZE
 #if __LONG_MAX == 0x7fffffffL
diff --git a/include/sys/user.h b/include/sys/user.h
index 78036da3..511caba3 100644
--- a/include/sys/user.h
+++ b/include/sys/user.h
@@ -8,7 +8,7 @@ extern "C" {
 #include <stdint.h>
 #include <unistd.h>

-#include <bits/alltype.h>
+#include <bits/alltypes.h>

 #undef __WORDSIZE
 #if __LONG_MAX == 0x7fffffffL


It seems like the issue was introduced here:

https://git.musl-libc.org/cgit/musl/commit/include/sys/reg.h?id=e709a6f07ade208ba513f9225222336f30c304b0

Thx!

[-- Attachment #2: Type: text/html, Size: 1706 bytes --]

Re: [musl] alltype header typo in reg and user

[Rich Felker]

On Fri, May 10, 2024 at 08:27:34PM -0700, Gonzalo Alvarez wrote:
> First report here - forgive me if I'm missing something.
> 
> I'm using musl to build a cross toolchain for risc-v (specifically the
> xuantie v0.7.1 vector c906v version). When using the headers to build the
> packages in the buildroot, I hit an issue when including either sys/reg.h
> or sys/user.h, since it looks like there was a recent change that added an
> include there to bring 'alltypes.h' into those files, but the change is
> missing the 's' at the end. The diff is more descriptive.

Thanks. Indeed, this was missed because sys/reg.h and sys/user.h are
not included anywhere in the library source and don't break build,
just the tiny number of programs using these obscure headers. I've got
yout patch queued (with commit message added) and will be pushing it
in a bit.

Rich