From: Rich Felker <dalias@libc.org>
To: Stefan Jumarea <stefanjumarea02@gmail.com>
Cc: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] mallocng: Add MTE support for Aarch64
Date: Mon, 10 Jun 2024 11:59:54 -0400 [thread overview]
Message-ID: <20240610155954.GM10433@brightrain.aerifal.cx> (raw)
In-Reply-To: <20240610123624.305051-2-stefanjumarea02@gmail.com>
On Mon, Jun 10, 2024 at 03:36:25PM +0300, Stefan Jumarea wrote:
> Add support for Memory Tagging Extension.
>
> All the memory tagging code is placed within compiler guards, and is
> enabled by using the `--enable-mte` configure option.
> The option can only be used if compiling for Aarch64.
>
> All the primitives for generating, storing and loading the memory tags
> are placed in a new header under `arch/aarch64/`.
>
> For now, only the actual user data is tagged. All metadata is untagged.
It's exciting to see a (presumably working) implementation of this --
mallocng was designed with the intent to support things like MTE. I
haven't read it in detail but I think to be acceptable upstream it
will need some adjustments. One very minor thing is that all the
uint64_t should be uintptr_t. But it looks like there's a lot of
repetitition of the pattern of getting the untagged pointer, where in
many cases, it could be done in the function the pointer is passed to
(things like get_meta).
I'll follow up with more detailed review later.
Rich
next prev parent reply other threads:[~2024-06-10 15:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 12:36 Stefan Jumarea
2024-06-10 15:59 ` Rich Felker [this message]
2024-06-11 14:09 ` Szabolcs Nagy
2024-06-11 14:46 ` Rich Felker
2024-06-11 15:37 ` Stefan Jumarea
2024-06-11 16:42 ` Rich Felker
2024-06-11 17:13 ` Stefan Jumarea
2024-06-11 19:39 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610155954.GM10433@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
--cc=stefanjumarea02@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).