From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <musl-return-21003-ml=inbox.vuxu.org@lists.openwall.com>
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,
	RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham
	autolearn_force=no version=3.4.4
Received: from second.openwall.net (second.openwall.net [193.110.157.125])
	by inbox.vuxu.org (Postfix) with SMTP id 82BF029CDF
	for <ml@inbox.vuxu.org>; Wed, 12 Jun 2024 16:13:54 +0200 (CEST)
Received: (qmail 5325 invoked by uid 550); 12 Jun 2024 14:13:50 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 5293 invoked from network); 12 Jun 2024 14:13:50 -0000
Date: Wed, 12 Jun 2024 10:14:05 -0400
From: Rich Felker <dalias@libc.org>
To: Meng Zhuo <mzh@mzh.io>
Cc: musl@lists.openwall.com
Message-ID: <20240612141405.GS10433@brightrain.aerifal.cx>
References: <20240612090018.258573-1-mzh@mzh.io>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240612090018.258573-1-mzh@mzh.io>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [musl] [PATCH 1/2] math: add riscv64 llround/llroundf

On Wed, Jun 12, 2024 at 05:00:17PM +0800, Meng Zhuo wrote:
> ---
>  src/math/riscv64/llround.c  | 16 ++++++++++++++++
>  src/math/riscv64/llroundf.c | 16 ++++++++++++++++
>  2 files changed, 32 insertions(+)
>  create mode 100644 src/math/riscv64/llround.c
>  create mode 100644 src/math/riscv64/llroundf.c
> 
> diff --git a/src/math/riscv64/llround.c b/src/math/riscv64/llround.c
> new file mode 100644
> index 00000000..fa646b5a
> --- /dev/null
> +++ b/src/math/riscv64/llround.c
> @@ -0,0 +1,16 @@
> +#include <math.h>
> +
> +#if __riscv_flen >= 64
> +
> +long long llround(double x)
> +{
> +	long long n;
> +	__asm__ ("fcvt.l.d %0, %1, rmm" : "=r"(n) : "f"(x));
> +	return n;
> +}
> +
> +#else
> +
> +#include "../llround.c"
> +
> +#endif
> diff --git a/src/math/riscv64/llroundf.c b/src/math/riscv64/llroundf.c
> new file mode 100644
> index 00000000..db2d58df
> --- /dev/null
> +++ b/src/math/riscv64/llroundf.c
> @@ -0,0 +1,16 @@
> +#include <math.h>
> +
> +#if __riscv_flen >= 32
> +
> +long long llroundf(float x)
> +{
> +	long long n;
> +	__asm__ ("fcvt.l.s %0, %1, rmm" : "=r"(n) : "f"(x));
> +	return n;
> +}
> +
> +#else
> +
> +#include "../llroundf.c"
> +
> +#endif
> -- 
> 2.39.2

Is there a reason you only did llround[f] and not lround[f]?

Rich