From: Rich Felker <dalias@libc.org>
To: Meng Zhuo <mzh@mzh.io>
Cc: musl@lists.openwall.com
Subject: Re: [musl] [PATCH v3] math: add riscv64 round/roundf
Date: Wed, 12 Jun 2024 11:44:10 -0400 [thread overview]
Message-ID: <20240612154410.GU10433@brightrain.aerifal.cx> (raw)
In-Reply-To: <20240612153105.335451-1-mzh@mzh.io>
On Wed, Jun 12, 2024 at 11:31:05PM +0800, Meng Zhuo wrote:
> ---
> v2 -> v3:
> * use x + x to check +-inf and NaN
> ---
> v1 -> v2:
> * drop ±inf check and use fabs as Rich suggested
> ---
> src/math/riscv64/round.c | 21 +++++++++++++++++++++
> src/math/riscv64/roundf.c | 21 +++++++++++++++++++++
> 2 files changed, 42 insertions(+)
> create mode 100644 src/math/riscv64/round.c
> create mode 100644 src/math/riscv64/roundf.c
>
> diff --git a/src/math/riscv64/round.c b/src/math/riscv64/round.c
> new file mode 100644
> index 00000000..28d05aed
> --- /dev/null
> +++ b/src/math/riscv64/round.c
> @@ -0,0 +1,21 @@
> +#include <math.h>
> +
> +#if __riscv_flen >= 64
> +
> +double round(double x)
> +{
> + if (isnan(x + x)) return x; // if x is +-inf or nan
> + if (fabs(x) >= 0x1p54) return x;
Why? I already gave you a single expression that covers all these
cases if you don't care about raising INVALID (I don't recall if
that's allowed here):
if (!(fabs(x) < 0x1p54)) return x;
Your new x+x *does* raise INVALID, so it has no advantages.
If the function needs to avoid raising INVALID, you need to check
isnan(x) (or !isfinite(x) is probably better) separately like you were
doing. We need to check this.
Rich
next prev parent reply other threads:[~2024-06-12 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 15:31 Meng Zhuo
2024-06-12 15:44 ` Rich Felker [this message]
2024-06-12 16:06 Meng Zhuo
2024-06-12 16:50 ` Szabolcs Nagy
2024-06-12 16:54 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612154410.GU10433@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
--cc=mzh@mzh.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).