From: Szabolcs Nagy <nsz@port70.net>
To: Meng Zhuo <mzh@mzh.io>
Cc: musl@lists.openwall.com
Subject: Re: [musl] [PATCH v3] math: add riscv64 round/roundf
Date: Wed, 12 Jun 2024 18:50:04 +0200 [thread overview]
Message-ID: <20240612165004.GI3766212@port70.net> (raw)
In-Reply-To: <20240612160612.362246-1-mzh@mzh.io>
* Meng Zhuo <mzh@mzh.io> [2024-06-13 00:06:12 +0800]:
> ---
> First of all, sorry for any inconvenience.
> This is my first time try to contribute with mail list.
> ---
> v1 -> v3:
> * using isfinite to check NaN,+-inf and in range without raising INVALID
> * inlined copysign(f)
> ---
> src/math/riscv64/round.c | 20 ++++++++++++++++++++
> src/math/riscv64/roundf.c | 20 ++++++++++++++++++++
> 2 files changed, 40 insertions(+)
> create mode 100644 src/math/riscv64/round.c
> create mode 100644 src/math/riscv64/roundf.c
>
> diff --git a/src/math/riscv64/round.c b/src/math/riscv64/round.c
> new file mode 100644
> index 00000000..6d91c093
> --- /dev/null
> +++ b/src/math/riscv64/round.c
> @@ -0,0 +1,20 @@
> +#include <math.h>
> +
> +#if __riscv_flen >= 64
> +
> +double round(double x)
> +{
> + if (!isfinite(x)) return x;
!isfinite(x) && fabs(x) >= 0x1p52
otherwise n can overflow below.
(note that the check can be a single cmp+branch on the bit representation of x)
> + double tmp;
> + long long n;
> + __asm__ ("fcvt.l.d %0, %1, rmm" : "=r"(n) : "f"(x));
> + __asm__ ("fcvt.d.l %0, %1" : "=f"(tmp) : "r"(n));
> + __asm__ ("fsgnj.d %0, %1, %2" : "=f"(x) : "f"(tmp), "f"(x));
i'd add a comment that the sign bit is only copied to handle round(-0.0)
> + return x;
> +}
> +
> +#else
> +
> +#include "../round.c"
> +
> +#endif
> diff --git a/src/math/riscv64/roundf.c b/src/math/riscv64/roundf.c
> new file mode 100644
> index 00000000..e67e791f
> --- /dev/null
> +++ b/src/math/riscv64/roundf.c
> @@ -0,0 +1,20 @@
> +#include <math.h>
> +
> +#if __riscv_flen >= 32
> +
> +float roundf(float x)
> +{
> + if (!isfinite(x)) return x;
&& fabs(x) >= 0x1p23
> + float tmp;
> + long n;
> + __asm__ ("fcvt.w.s %0, %1, rmm" : "=r"(n) : "f"(x));
> + __asm__ ("fcvt.s.w %0, %1" : "=f"(tmp) : "r"(n));
> + __asm__ ("fsgnj.s %0, %1, %2" : "=f"(x) : "f"(tmp), "f"(x));
> + return x;
> +}
> +
> +#else
> +
> +#include "../roundf.c"
> +
> +#endif
> --
> 2.39.2
next prev parent reply other threads:[~2024-06-12 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 16:06 Meng Zhuo
2024-06-12 16:50 ` Szabolcs Nagy [this message]
2024-06-12 16:54 ` Szabolcs Nagy
-- strict thread matches above, loose matches on Subject: below --
2024-06-12 15:31 Meng Zhuo
2024-06-12 15:44 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612165004.GI3766212@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
--cc=mzh@mzh.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).