From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <musl-return-21011-ml=inbox.vuxu.org@lists.openwall.com>
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,
	RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham
	autolearn_force=no version=3.4.4
Received: from second.openwall.net (second.openwall.net [193.110.157.125])
	by inbox.vuxu.org (Postfix) with SMTP id E47A22B451
	for <ml@inbox.vuxu.org>; Wed, 12 Jun 2024 18:54:42 +0200 (CEST)
Received: (qmail 27699 invoked by uid 550); 12 Jun 2024 16:54:38 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 27666 invoked from network); 12 Jun 2024 16:54:38 -0000
Date: Wed, 12 Jun 2024 18:54:30 +0200
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Cc: Meng Zhuo <mzh@mzh.io>
Message-ID: <20240612165430.GK3766212@port70.net>
Mail-Followup-To: musl@lists.openwall.com, Meng Zhuo <mzh@mzh.io>
References: <20240612160612.362246-1-mzh@mzh.io>
 <20240612165004.GI3766212@port70.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240612165004.GI3766212@port70.net>
Subject: Re: [musl] [PATCH v3] math: add riscv64 round/roundf

* Szabolcs Nagy <nsz@port70.net> [2024-06-12 18:50:04 +0200]:
> > +double round(double x)
> > +{
> > +	if (!isfinite(x)) return x;
> 
> !isfinite(x) && fabs(x) >= 0x1p52

i meant ||, not &&

> 
> otherwise n can overflow below.
> 
> (note that the check can be a single cmp+branch on the bit representation of x)