mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: erny hombre <hombre67@gmx.at>
Cc: musl@lists.openwall.com
Subject: Re: [musl] Re: possible bug in syslog
Date: Thu, 13 Jun 2024 11:29:31 -0400	[thread overview]
Message-ID: <20240613152931.GX10433@brightrain.aerifal.cx> (raw)
In-Reply-To: <trinity-69d19835-1ce3-4004-a813-ceb7e21e9058-1718290318959@3c-app-gmx-bap11>

On Thu, Jun 13, 2024 at 04:51:59PM +0200, erny hombre wrote:
> Hello,
> 
> Rich wrote:
> > This assertion itself is not valid; the whole reason a LOG_MAKEPRI
> > macro exists is that it's not guaranteed that the packing be
> > simple or.
> 
> Here
> (https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/functions/syslog.html)
> I found this:
> Values of the priority argument are formed by OR'ing together a
> severity-level value and an optional facility value.
> 
> So I think a simple or should be correct.

Oh, I completely missed that and thought this was an extension.
Indeed, it's the LOG_MAKEPRI thing that's nonstandard way to do
something that already has a standard way to do it, and since our
definition of it is wrong, it just needs to be fixed.

Rich

      reply	other threads:[~2024-06-13 15:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-13 14:51 erny hombre
2024-06-13 15:29 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240613152931.GX10433@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=hombre67@gmx.at \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).