[musl] Re: possible bug in syslog

[musl] Re: possible bug in syslog

[erny hombre]

Hello,

Rich wrote:
> This assertion itself is not valid; the whole reason a LOG_MAKEPRI macro exists is that it's not guaranteed that the packing be simple or.

Here (https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/functions/syslog.html) I found this:
Values of the priority argument are formed by OR'ing together a severity-level value and an optional facility value.

So I think a simple or should be correct.

Regards
Erwin

Re: [musl] Re: possible bug in syslog

[Rich Felker]

On Thu, Jun 13, 2024 at 04:51:59PM +0200, erny hombre wrote:
> Hello,
> 
> Rich wrote:
> > This assertion itself is not valid; the whole reason a LOG_MAKEPRI
> > macro exists is that it's not guaranteed that the packing be
> > simple or.
> 
> Here
> (https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/functions/syslog.html)
> I found this:
> Values of the priority argument are formed by OR'ing together a
> severity-level value and an optional facility value.
> 
> So I think a simple or should be correct.

Oh, I completely missed that and thought this was an extension.
Indeed, it's the LOG_MAKEPRI thing that's nonstandard way to do
something that already has a standard way to do it, and since our
definition of it is wrong, it just needs to be fixed.

Rich