From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 0B7CB2B74A for ; Thu, 13 Jun 2024 17:29:20 +0200 (CEST) Received: (qmail 30592 invoked by uid 550); 13 Jun 2024 15:29:16 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 30554 invoked from network); 13 Jun 2024 15:29:15 -0000 Date: Thu, 13 Jun 2024 11:29:31 -0400 From: Rich Felker To: erny hombre Cc: musl@lists.openwall.com Message-ID: <20240613152931.GX10433@brightrain.aerifal.cx> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] Re: possible bug in syslog On Thu, Jun 13, 2024 at 04:51:59PM +0200, erny hombre wrote: > Hello, > > Rich wrote: > > This assertion itself is not valid; the whole reason a LOG_MAKEPRI > > macro exists is that it's not guaranteed that the packing be > > simple or. > > Here > (https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/functions/syslog.html) > I found this: > Values of the priority argument are formed by OR'ing together a > severity-level value and an optional facility value. > > So I think a simple or should be correct. Oh, I completely missed that and thought this was an extension. Indeed, it's the LOG_MAKEPRI thing that's nonstandard way to do something that already has a standard way to do it, and since our definition of it is wrong, it just needs to be fixed. Rich