From: Rich Felker <dalias@libc.org>
To: Collin Funk <collin.funk1@gmail.com>
Cc: Leah Neukirchen <leah@vuxu.org>, musl@lists.openwall.com
Subject: Re: [musl] getusershell should ignore comments and empty lines.
Date: Fri, 21 Jun 2024 21:06:25 -0400 [thread overview]
Message-ID: <20240622010625.GD10433@brightrain.aerifal.cx> (raw)
In-Reply-To: <7389f0ee-aa40-471a-8aab-dd01cc6885bf@gmail.com>
On Fri, May 24, 2024 at 05:16:41PM -0700, Collin Funk wrote:
> Hi Rich,
>
> On 5/23/24 8:27 AM, Rich Felker wrote:
> >> In general, musl policy is to support at most what's consistent
> >> between historical implementations.
> >>
> >> It seems like they all ignore lines that start with a '#'. They might
> >> (not clear from the above) also ignore blank lines.
> >>
> >> The minimal change both to avoid clashing with vaguely reasonable
> >> things user might want to put there (and violating least surprise),
> >> and to support the common behavior, seems to be just looping as long
> >> as the line is empty or starts with #.
> >
> > Something like this?
>
> Thanks for explaining how Musl handles things.
>
> I haven't tested your patch but it looks correct.
Applied. Let me know if anything seems wrong still.
prev parent reply other threads:[~2024-06-22 1:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 3:17 Collin Funk
2024-05-23 13:21 ` Rich Felker
2024-05-23 13:45 ` Leah Neukirchen
2024-05-23 13:59 ` Collin Funk
2024-05-23 14:47 ` Rich Felker
2024-05-23 15:27 ` Rich Felker
2024-05-25 0:16 ` Collin Funk
2024-06-22 1:06 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240622010625.GD10433@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=collin.funk1@gmail.com \
--cc=leah@vuxu.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).