From: Rich Felker <dalias@libc.org>
To: 仇玉加 <1066414879@qq.com>
Cc: musl <musl@lists.openwall.com>
Subject: Re: [musl] The sigtimedwait function can't return EINTR
Date: Wed, 26 Jun 2024 11:30:46 -0400 [thread overview]
Message-ID: <20240626153045.GM10433@brightrain.aerifal.cx> (raw)
In-Reply-To: <tencent_BC5BFBDE554CDA6D16C75C535771D4896208@qq.com>
On Tue, Jun 25, 2024 at 02:14:29PM +0800, 仇玉加 wrote:
> Hi,
>
>
> Why not check for EINTR errors in sigwait function instead of sigtimedwait function?
> In posix, the sigtimedwait function can return an EINTR error.
It's a may fail, not a shall fail, so either behavior is allowed.
> Can you give me a reason for this situation?
Commit 0a949ebdf0b9fc054ea868bd049c8f2c7aed973e documents that it was
necessary that sigwait not fail with EINTR, so the logic to retry in
EINTR had to be added either in sigwait or sigtimedwait.
Generally we don't utilize "may fail" unless there's a good reason. In
the case of sigtimedwait, I think my reasoning was that it's already
waiting for one of a set of signals, and you could just include the
signal(s) you want to be interrupted by in that set. Since the EINTR
condition is not mandatory, this is the only portable way to do it.
Rich
prev parent reply other threads:[~2024-06-26 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 6:14 =?gb18030?B?s/DT8bzT?=
2024-06-26 15:30 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626153045.GM10433@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=1066414879@qq.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).