mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: Charlie Qiu <longfeiqiu2012@gmail.com>
Cc: musl@lists.openwall.com
Subject: Re: [musl] A typo in Makefile?
Date: Fri, 9 Aug 2024 23:06:52 -0400	[thread overview]
Message-ID: <20240810030652.GF10433@brightrain.aerifal.cx> (raw)
In-Reply-To: <CANvb-JSfJOaBN6nEgY3UKkiRMbrY-qz+TF+qeE7M6GpPYsNJYg@mail.gmail.com>

On Fri, Aug 09, 2024 at 10:05:13PM -0400, Charlie Qiu wrote:
> Hi all,
> 
> I was reading the musl Makefile (latest commit dd1e63). Line 113 reads:
> 
> obj/crt/crt1.o obj/crt/scrt1.o obj/crt/rcrt1.o obj/ldso/dlstart.lo:
> $(srcdir)/arch/$(ARCH)/crt_arch.h
> 
> Should the second file be Scrt1.o (capital S) rather than scrt1.o (small
> s)? The capital version is used on line 117 below and all other places. The
> small s seems to be introduced in commit 2f853d (support out-of-tree build).

Thanks! Indeed this seems to be a mistake. I'll commit a fix.

Rich

      reply	other threads:[~2024-08-10  3:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-10  2:05 Charlie Qiu
2024-08-10  3:06 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240810030652.GF10433@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=longfeiqiu2012@gmail.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).