From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id D93DB2221E for ; Sat, 10 Aug 2024 05:07:05 +0200 (CEST) Received: (qmail 21875 invoked by uid 550); 10 Aug 2024 03:06:59 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 21837 invoked from network); 10 Aug 2024 03:06:59 -0000 Date: Fri, 9 Aug 2024 23:06:52 -0400 From: Rich Felker To: Charlie Qiu Cc: musl@lists.openwall.com Message-ID: <20240810030652.GF10433@brightrain.aerifal.cx> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] A typo in Makefile? On Fri, Aug 09, 2024 at 10:05:13PM -0400, Charlie Qiu wrote: > Hi all, > > I was reading the musl Makefile (latest commit dd1e63). Line 113 reads: > > obj/crt/crt1.o obj/crt/scrt1.o obj/crt/rcrt1.o obj/ldso/dlstart.lo: > $(srcdir)/arch/$(ARCH)/crt_arch.h > > Should the second file be Scrt1.o (capital S) rather than scrt1.o (small > s)? The capital version is used on line 117 below and all other places. The > small s seems to be introduced in commit 2f853d (support out-of-tree build). Thanks! Indeed this seems to be a mistake. I'll commit a fix. Rich