From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <musl-return-21303-ml=inbox.vuxu.org@lists.openwall.com>
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.3 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,
	RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4
Received: from second.openwall.net (second.openwall.net [193.110.157.125])
	by inbox.vuxu.org (Postfix) with SMTP id 35DF42133A
	for <ml@inbox.vuxu.org>; Fri, 16 Aug 2024 19:00:48 +0200 (CEST)
Received: (qmail 19995 invoked by uid 550); 16 Aug 2024 17:00:44 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 19946 invoked from network); 16 Aug 2024 17:00:43 -0000
Date: Fri, 16 Aug 2024 13:00:35 -0400
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Message-ID: <20240816170034.GT10433@brightrain.aerifal.cx>
References: <7b3b00712ea64482a9f3ecabe64306fa@boeing.com>
 <20240816073538.GC3766212@port70.net>
 <20240816155729.GS10433@brightrain.aerifal.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240816155729.GS10433@brightrain.aerifal.cx>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [musl] libc-test contribution

On Fri, Aug 16, 2024 at 11:57:29AM -0400, Rich Felker wrote:
> On Fri, Aug 16, 2024 at 09:35:38AM +0200, Szabolcs Nagy wrote:
> > * Ward, Ryan C <ryan.c.ward3@boeing.com> [2024-08-16 01:06:55 +0000]:
> > > Hello,
> > > 
> > > I would like to start contributing some test cases to libc-test. I have 
> > > started with testing some simple recent regressions (e.g. a test for
> > > the recent fix commit 947b4574), and am aiming to start filling in
> > > missing functional test coverage. Am I able to submit the test
> > > directly to this mailing list, and are there any other immediate 
> > > areas of libc-test that need implementation?
> > 
> > this list is fine
> > 
> > there are many areas missing
> > but they need test infrastucture
> > eg networking tests depending on
> > /etc/resolv.conf need to run in
> > a separate mount namespace.
> 
> I could try writing a helper module to do this. Basically it would
> just unshare into a new user+mount+network namespace and, if
> /etc/resolv.conf exists, bind-mount an empty file over it. Then you
> can bind port 53 and it will intercept all queries, and you don't have
> to worry about anything going out to the real network or having
> network-dependent behaviors.

Something like this:

#define _GNU_SOURCE
#include <stdio.h>
#include <unistd.h>
#include <sched.h>
#include <sys/mount.h>
#include <fcntl.h>
#include <stdlib.h>
#include <sys/socket.h>
#include <sys/ioctl.h>
#include <net/if.h>
#include <netinet/in.h>

int enter_dns_test_ns()
{
	if (unshare(CLONE_NEWUSER|CLONE_NEWNS|CLONE_NEWNET) < 0)
		return -1;
	int s = socket(AF_INET, SOCK_DGRAM, IPPROTO_IP);
	if (s < 0) return -1;
	struct ifreq ifr = {
		.ifr_name = "lo",
		.ifr_addr = (union { struct sockaddr_in sin; struct sockaddr sa; }){{
			.sin_family = AF_INET,
			.sin_port = 0,
			.sin_addr = htonl(0x7f000001),
			}}.sa,
	};
	if (ioctl(s, SIOCSIFADDR, &ifr) < 0)
		return -1;
	if (ioctl(s, SIOCGIFFLAGS, &ifr) < 0)
		return -1;
	ifr.ifr_flags |= IFF_UP;
	if (ioctl(s, SIOCSIFFLAGS, &ifr) < 0)
		return -1;
	char tmp[] = "/tmp/emptyXXXXXX";
	int fd = mkostemp(tmp, O_CLOEXEC);
	if (fd < 0) return -1;
	int r = mount(tmp, "/etc/resolv.conf", 0, MS_BIND, 0);
	unlink(tmp);
	return r;
}