mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: psykose <alice@ayaya.dev>
Cc: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] fix MINSIGSTKSZ and SIGSTKSZ for powerpc64
Date: Thu, 29 Aug 2024 08:57:27 -0400	[thread overview]
Message-ID: <20240829125727.GK10433@brightrain.aerifal.cx> (raw)
In-Reply-To: <D3S38EL8UO9V.U731IQFLR32X@ayaya.dev>

On Thu, Aug 29, 2024 at 05:38:42AM +0200, psykose wrote:
> since kernel commit 2f82ec19757f58549467db568c56e7dfff8af283
> (https://github.com/torvalds/linux/commit/2f82ec19757f58549467db568c56e7dfff8af283)
> the kernel has updated these minimum values. having these small values breaks
> sysconf(_SC_MINSIGSTKSZ) too; it returns 4224 in musl currently which ends up
> returning ENOMEM from the syscall made in sigaltstack.
> 
> raising these to match the kernel fixes sigaltstack use on powerpc64(le).
> caught by glib's 2.82 testsuite

I don't follow how you're claiming sysconf(_SC_MINSIGSTKSZ) is broken.
It will just return the kernel-provided value on new kernels that
insist on having a larger stack. In particular I don't see where the
value 4224 is supposed to be coming from. If there's something I'm
missing, please explain.

Changing the macros is ABI breakage, perhaps minor, but still not
nice. My leaning if any change is made would be to remove them, but
unfortunately the Austin Group didn't seem to have gotten the sysconf
stuff (and making these macros optional) into Issue 8, so they're
still mandatory. So I'm not sure what is best to do. Ultimately, due
to kernel bad behavior ignoring the "don't break userspace" rule and
ignoring POSIX, we're in a situation where the macros are required but
necessarily don't actually work, and the only way to make a reliably
working application is to use the not-yet-standard sysconf() lookups
instead.

Regardless of how MINSIGSTKSZ is handled, increasing SIGSTKSZ from 10k
to 32k makes no sense. At most it needs to be increased by the
increase in MINSIGSTKSZ, or perhaps twice that if the goal is to allow
for 2 signal frames (but we currently don't do that in sysconf, so if
that's desirable it should be proposed as its own thing not a
special-case jacking up of the value for one arch).

Rich

  reply	other threads:[~2024-08-29 12:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29  3:38 psykose
2024-08-29 12:57 ` Rich Felker [this message]
2024-08-29 16:00   ` alice
2024-08-29 19:03     ` Rich Felker
2024-08-29 19:11       ` alice
2024-08-29 20:23         ` Rich Felker
2024-08-31 16:33           ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240829125727.GK10433@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=alice@ayaya.dev \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).