[musl] Storing common macros and function stubs in libc-test

[musl] Storing common macros and function stubs in libc-test

[Gardner, Ryan P]

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

Hello,

I am currently writing some test cases to contribute to libc-test.
In regards to reusing common macros and function stubs, where would
be the most appropriate place to put these? Should these be added
to `test.h`? Would a new `utils.h` header file be more appropriate?
A new file would ensure no rework/unexpected redefines with already
existing tests. Or should the macros needed for a given test be
defined within that test file, even if many tests use the same
macros. For example #define TEST(c, ...).

Kind regards,
Ryan

[-- Attachment #2: Type: text/html, Size: 2646 bytes --]

Re: [musl] Storing common macros and function stubs in libc-test

[Szabolcs Nagy]

* Gardner, Ryan P <ryan.p.gardner@boeing.com> [2024-09-06 01:36:17 +0000]:
> Hello,
> 
> I am currently writing some test cases to contribute to libc-test.
> In regards to reusing common macros and function stubs, where would
> be the most appropriate place to put these? Should these be added
> to `test.h`? Would a new `utils.h` header file be more appropriate?
> A new file would ensure no rework/unexpected redefines with already
> existing tests. Or should the macros needed for a given test be
> defined within that test file, even if many tests use the same
> macros. For example #define TEST(c, ...).

if the macro definition is relatively simple then keep it in the test
so users can more easily use the test outside the test system.

otherwise if you need a lot of shared macros then utils.h is fine.