From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 457422EDBB for ; Wed, 23 Oct 2024 00:17:32 +0200 (CEST) Received: (qmail 31833 invoked by uid 550); 22 Oct 2024 22:17:27 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com x-ms-reactions: disallow Received: (qmail 31795 invoked from network); 22 Oct 2024 22:17:27 -0000 Date: Wed, 23 Oct 2024 00:17:19 +0200 From: Szabolcs Nagy To: Rich Felker Cc: Alyssa Ross , musl@lists.openwall.com Message-ID: <20241022221719.GI2724612@port70.net> Mail-Followup-To: Rich Felker , Alyssa Ross , musl@lists.openwall.com References: <20241019181638.25021-2-hi@alyssa.is> <20241022100349.GH2724612@port70.net> <87plns9vzv.fsf@alyssa.is> <20241022163627.GR10433@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241022163627.GR10433@brightrain.aerifal.cx> Subject: Re: [musl] [PATCH libc-test v3] functional: add mntent test * Rich Felker [2024-10-22 12:36:29 -0400]: > On Tue, Oct 22, 2024 at 02:12:52PM +0200, Alyssa Ross wrote: > > Szabolcs Nagy writes: > > > > > * Alyssa Ross [2024-10-19 20:16:39 +0200]: > > >> This only checks reading an fstab from an stream. I haven't written > > >> tests for setmntent(), addmntent(), or hasmntnent(). > > >> > > >> test_getmntent exposes a bug in musl 1.2.3 where lines omitting the > > >> final two fields, which are supposed to be optional according to > > >> fstab(5), are not accepted. It also exposes a current bug, where if > > >> the numeric fields are omitted, the last field seen will have a > > >> newline appended to its value. The tests all pass on Glibc. > > >> --- > > >> v3: updated description for current musl > > >> v2: https://inbox.vuxu.org/musl/20210821085420.474615-3-hi@alyssa.is/ > > >> > > >> Previously I had a second, optional patch, that would have tested the > > >> behavior of a single-field mntent entry. I've dropped that one, because > > >> musl chose not to match Glibc in accepting it. > > >> > > > > > > patch looks ok. it fails with > > > > > > src/functional/mntent.c:47: !strcmp(m->mnt_opts, "defaults") failed > > > FAIL src/functional/mntent-static.exe [status 1] > > > src/functional/mntent.c:47: !strcmp(m->mnt_opts, "defaults") failed > > > FAIL src/functional/mntent.exe [status 1] > > > > > > i guess this should be fixed > > > > Fix has already been submitted here: > > https://inbox.vuxu.org/musl/20241019181320.23977-2-hi@alyssa.is/ > > > > I think it should pass on musl 1.2.4. > > Yep, thanks. I'll get this and some other new stuff committed. ok. i committed the libc-test patch.