From: Rich Felker <dalias@libc.org>
To: lihua.zhao.cn@windriver.com
Cc: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] mman: correct length check in __shm_mapname
Date: Mon, 4 Nov 2024 20:46:53 -0500 [thread overview]
Message-ID: <20241105014652.GE10433@brightrain.aerifal.cx> (raw)
In-Reply-To: <20241105010633.1512010-1-lihua.zhao.cn@windriver.com>
On Tue, Nov 05, 2024 at 09:06:33AM +0800, lihua.zhao.cn@windriver.com wrote:
> From: Lihua Zhao <lihua.zhao.cn@windriver.com>
>
> changed the length check from `p-name > NAME_MAX` to
> `p-name >= NAME_MAX` to correctly account for the null terminator.
>
> Signed-off-by: Lihua Zhao <lihua.zhao.cn@windriver.com>
> ---
> src/mman/shm_open.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mman/shm_open.c b/src/mman/shm_open.c
> index 79784bd3..2359f067 100644
> --- a/src/mman/shm_open.c
> +++ b/src/mman/shm_open.c
> @@ -15,7 +15,7 @@ char *__shm_mapname(const char *name, char *buf)
> errno = EINVAL;
> return 0;
> }
> - if (p-name > NAME_MAX) {
> + if (p-name >= NAME_MAX) {
> errno = ENAMETOOLONG;
> return 0;
> }
> --
> 2.43.0
This doesn't look correct. Can you explain what problem you think it's
solving?
Rich
next prev parent reply other threads:[~2024-11-05 1:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 1:06 lihua.zhao.cn
2024-11-05 1:46 ` Rich Felker [this message]
2024-11-05 2:03 ` Zhao, Lihua (CN)
2024-11-05 3:00 ` Rich Felker
2024-11-05 4:56 ` [musl] [PATCH v2] " lihua.zhao.cn
2024-11-05 5:15 ` Rich Felker
2024-11-05 6:06 ` Zhao, Lihua (CN)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105014652.GE10433@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=lihua.zhao.cn@windriver.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).