mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: Alejandro Colomar <alx@kernel.org>
Cc: musl@lists.openwall.com
Subject: Re: [musl] sgetspent(3) on musl
Date: Fri, 29 Nov 2024 01:11:44 -0500	[thread overview]
Message-ID: <20241129061143.GI10433@brightrain.aerifal.cx> (raw)
In-Reply-To: <20241127121020.lrhi2s7hgilrjc75@devuan>

On Wed, Nov 27, 2024 at 01:10:20PM +0100, Alejandro Colomar wrote:
> Hi Rich,
> 
> Link: <https://github.com/shadow-maint/shadow/pull/1115#issuecomment-2466994769>
> 
> There seems to be a prototype for sgetspent(3) on musl libc, but I don't
> find an definition.  The prototype is there since commit 0.  Is that a
> bug?  (It looks like a bug, unless I'm missing something.)  This results
> in linker errors.  Should the prototype be removed, or the definition be
> added?

I think having the declaration there is just an oversight. Unless
we've encountered things that need the missing function, we should
probably just remove the declaration.

FWIW though I don't generally expect spurious declarations like this
to do any harm -- detection should be via a compile-and-link test not
just looking for a declaration. Is there a build system these days
that's doing purely declaration-based detection?

Rich

  reply	other threads:[~2024-11-29  6:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-27 12:10 Alejandro Colomar
2024-11-29  6:11 ` Rich Felker [this message]
2024-11-29  6:35   ` Jeffrey Walton
2024-11-29 12:29     ` Alejandro Colomar
2024-11-29 12:22   ` Alejandro Colomar
     [not found]   ` <j4chwyy4onh2hs4yetqmy6fysovhrsxwdcn7svxdfuec5f6czv@3opbnluima4w>
     [not found]     ` <20250523135402.GL1827@brightrain.aerifal.cx>
2025-05-23 14:44       ` Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241129061143.GI10433@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=alx@kernel.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).