From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 9FAE720CF5 for ; Sun, 9 Feb 2025 15:04:38 +0100 (CET) Received: (qmail 27871 invoked by uid 550); 9 Feb 2025 14:04:34 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com x-ms-reactions: disallow Received: (qmail 27846 invoked from network); 9 Feb 2025 14:04:33 -0000 Date: Sun, 9 Feb 2025 09:04:24 -0500 From: Rich Felker To: Yao Zi Cc: musl@lists.openwall.com Message-ID: <20250209140424.GX10433@brightrain.aerifal.cx> References: <20241118034446.14072-2-ziyao@disroot.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] [RESEND PATCH] ldso: don't reclaim zero-memory-sized segments On Sat, Feb 08, 2025 at 05:51:01AM +0000, Yao Zi wrote: > On Mon, Nov 18, 2024 at 03:44:47AM +0000, Yao Zi wrote: > > Some weird linkers may emit PT_LOAD segments with memsz = 0. ELF > > specification does not forbid this, but such a segment with non-zero > > p_vaddr will result in reclaiming of invalid memory address. > > > > This patch skips such segments during reclaiming for better > > compatibility. > > Ping on this patch, someone has been hitting this[1]. > > Thanks for your time and review! > > > Signed-off-by: Yao Zi > > --- > > ldso/dynlink.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/ldso/dynlink.c b/ldso/dynlink.c > > index 3b57c07f..715948f4 100644 > > --- a/ldso/dynlink.c > > +++ b/ldso/dynlink.c > > @@ -616,6 +616,7 @@ static void reclaim_gaps(struct dso *dso) > > for (; phcnt--; ph=(void *)((char *)ph+dso->phentsize)) { > > if (ph->p_type!=PT_LOAD) continue; > > if ((ph->p_flags&(PF_R|PF_W))!=(PF_R|PF_W)) continue; > > + if (ph->p_memsz == 0) continue; > > reclaim(dso, ph->p_vaddr & -PAGE_SIZE, ph->p_vaddr); > > reclaim(dso, ph->p_vaddr+ph->p_memsz, > > ph->p_vaddr+ph->p_memsz+PAGE_SIZE-1 & -PAGE_SIZE); > > -- > > 2.46.0 > > > > [1]: https://lists.nongnu.org/archive/html/tinycc-devel/2024-10/msg00012.html Thanks for the ping. Applying.