[musl] [PATCH] src: string: Replace unsafe strcpy with strncat in strcat()

[Anton Moryakov <ant.v.moryakov@gmail.com>]

Static analyzer reported:
PROC_USE.VULNERABLE Use of vulnerable function 'strcpy' at strcat.c:5. This function is unsafe, use strncpy instead.

Corrections explained:
Replaced the vulnerable function strcpy with strncat in strcat()
to prevent potential buffer overflows.

Previous code:
    strcpy(dest + strlen(dest), src);

New code:
    strncat(dest, src, strlen(src));

This improves security but does not guarantee full buffer safety. 
For complete protection, dest_size should be explicitly checked

Triggers found by static analyzer Svace.

Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>

---
 src/string/strcat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/string/strcat.c b/src/string/strcat.c
index 33f749b1..d341facf 100644
--- a/src/string/strcat.c
+++ b/src/string/strcat.c
@@ -2,6 +2,6 @@
 
 char *strcat(char *restrict dest, const char *restrict src)
 {
-	strcpy(dest + strlen(dest), src);
+    strncat(dest, src, strlen(src));
 	return dest;
 }
-- 
2.30.2