Re: [musl] [PATCH] i386, x86_64: Set the symbol type for the START function.

[Rich Felker <dalias@libc.org>]

On Sat, Nov 23, 2024 at 01:19:51AM +0100, Alex Rønne Petersen wrote:
> As for other architectures. Noticed this while running Zig's gen_stubs.zig tool.
> ---
>  arch/i386/crt_arch.h   | 1 +
>  arch/x86_64/crt_arch.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/i386/crt_arch.h b/arch/i386/crt_arch.h
> index 43c8477a..1a80fce3 100644
> --- a/arch/i386/crt_arch.h
> +++ b/arch/i386/crt_arch.h
> @@ -3,6 +3,7 @@ __asm__(
>  ".weak _DYNAMIC \n"
>  ".hidden _DYNAMIC \n"
>  ".global " START "\n"
> +".type " START ",%function \n"
>  START ":\n"
>  "	xor %ebp,%ebp \n"
>  "	mov %esp,%eax \n"
> diff --git a/arch/x86_64/crt_arch.h b/arch/x86_64/crt_arch.h
> index 3eec61bd..b1c9c476 100644
> --- a/arch/x86_64/crt_arch.h
> +++ b/arch/x86_64/crt_arch.h
> @@ -1,6 +1,7 @@
>  __asm__(
>  ".text \n"
>  ".global " START " \n"
> +".type " START ",%function \n"
>  START ": \n"
>  "	xor %rbp,%rbp \n"
>  "	mov %rsp,%rdi \n"
> -- 
> 2.40.1

Looks ok but was missing x32. I'll add it when merging.

Rich