mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: Damian McGuckin <damianm@esi.com.au>
Cc: MUSL <musl@lists.openwall.com>
Subject: Re: [musl] Comment in ccosh()
Date: Sun, 6 Jul 2025 23:31:49 +0200	[thread overview]
Message-ID: <20250706213149.GJ288056@port70.net> (raw)
In-Reply-To: <ac6ad9af-dc53-3a5b-67f5-e1d46d20dfc6@esi.com.au>

* Damian McGuckin <damianm@esi.com.au> [2025-07-02 15:17:20 +1000]:

> 
> There is a comment in ccoshf()
> 
> 	 /* x < 88.7: expf(|x|) won't overflow */
> 
> where is correct
> 
> The equivalent in ccosh() which says:
> 
> 	/* x < 710: exp(|x|) won't overflow */
> 
> This is far less concise than the earlier case.  More strictly
> 
> 	 /* x < 709.78: exp(|x|) won't overflow */
> 
> Am I being overly pedantic?

i guess the comment is sloppy

i think if you submit such a patch it can be accepted.

(or reword it in another way so it is not actually false)

> 
> Thanks - Damian

  reply	other threads:[~2025-07-06 21:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02  5:17 Comment in ccosh() Damian McGuckin
2025-07-06 21:31 ` Szabolcs Nagy [this message]
2025-07-07  3:16   ` [musl] Re: spam>Re: [musl] " Damian McGuckin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250706213149.GJ288056@port70.net \
    --to=nsz@port70.net \
    --cc=damianm@esi.com.au \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).