From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 85F4D2F2A9 for ; Sun, 6 Jul 2025 23:32:04 +0200 (CEST) Received: (qmail 10238 invoked by uid 550); 6 Jul 2025 21:31:59 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com x-ms-reactions: disallow Received: (qmail 10215 invoked from network); 6 Jul 2025 21:31:59 -0000 Date: Sun, 6 Jul 2025 23:31:49 +0200 From: Szabolcs Nagy To: Damian McGuckin Cc: MUSL Message-ID: <20250706213149.GJ288056@port70.net> Mail-Followup-To: Damian McGuckin , MUSL References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [musl] Comment in ccosh() * Damian McGuckin [2025-07-02 15:17:20 +1000]: > > There is a comment in ccoshf() > > /* x < 88.7: expf(|x|) won't overflow */ > > where is correct > > The equivalent in ccosh() which says: > > /* x < 710: exp(|x|) won't overflow */ > > This is far less concise than the earlier case. More strictly > > /* x < 709.78: exp(|x|) won't overflow */ > > Am I being overly pedantic? i guess the comment is sloppy i think if you submit such a patch it can be accepted. (or reword it in another way so it is not actually false) > > Thanks - Damian