Re: [musl] getpass() feature test macro

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Rich,

Thanks for your super quick feedback, as usual!

On Wed, 9 Jul 2025 19:56:14 -0400
Rich Felker <dalias@libc.org> wrote:

> On Thu, Jul 10, 2025 at 12:20:42AM +0200, Thorsten Glaser wrote:
> > On Wed, 9 Jul 2025, Thomas Petazzoni wrote:
> >   
> > >               _XOPEN_SOURCE && ! (_POSIX_C_SOURCE >= 200112L)  
> 
> This looks like a bug: a search for getpass in POSIX returns
> no match.  

A bug in the getpass(3) documentation?

> It was probably in an older version of POSIX (possibly XSI shaded, not
> sure). Generally we don't provide full compat with older versions of
> the standards, since it turns into a mess of version conditions and
> programs using a mix of older stuff are usually better off just with
> _DEFAULT_SOURCE (alias _BSD_SOURCE). There are a few exceptions for
> stuff that's still widely used like gethostby* that recent standards
> removed, but I'm not sure it would make sense to treat getpass special
> like that being that it's a rarely used and IIRC removed a long time
> ago.

Hm, thanks but it still isn't clear to me. If the issue is in the gcr
code base, which needs to define another feature macro, I'd like to
have some compelling evidence that the code is incorrect and needs to
define some other feature macro to use getpass().

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com