mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Alexander Sosedkin <monk@unboiled.info>
To: musl@lists.openwall.com
Subject: [musl] $ORIGIN rpath expansion without /proc: code looks wrong
Date: Wed, 17 Nov 2021 15:04:15 +0100	[thread overview]
Message-ID: <27df10f8-c044-e960-350a-d0a40b774bed@unboiled.info> (raw)

Hello, I've encountered a case of a binary with an rpath of
/some/meaningful/lib:$ORIGIN/../lib
not starting up due to not finding /some/meaningful/lib/libxyz.so.
ldd'ing said it's there though.
And the library was found alright when I patchelf'd rpath to just
/some/meaningful/lib

I dug into musl code and came across that bit that checks /proc.
Sure enough, when I tried mounting /proc, it started working fine.
Yet the error handling from accessing /proc puzzles me:

ldso/dynlink.c, fixup_rpath():
                 l = readlink("/proc/self/exe", buf, buf_size);
                 if (l == -1) switch (errno) {
                 case ENOENT:
                 case ENOTDIR:
                 case EACCES:
                         break;
                 default:
                         return -1;
                 }
                 if (l >= buf_size)
                         return 0;
                 buf[l] = 0;
                 origin = buf;

hitting that break like I had means zeroing buf[-1], right?
Could somebody take a look at this and double-check that
this codepath makes sense?
My attempts at comprehending it fail irrecoverably at this line.

(CC me on replies, please.
  No nice context to provide, building my own toolchain at
  https://github.com/t184256/bootstrap-from-tcc)

             reply	other threads:[~2021-11-17 14:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 14:04 Alexander Sosedkin [this message]
2021-11-17 17:00 ` Érico Nogueira
2021-11-17 19:25   ` Alexander Sosedkin
2021-11-18 19:15     ` Érico Nogueira
2021-11-17 20:01   ` Jeffrey Walton
2021-11-18 19:21     ` Érico Nogueira
2021-11-18 19:41       ` Alexander Sosedkin
2021-11-18 19:42       ` Jeffrey Walton
2021-11-18 20:30         ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27df10f8-c044-e960-350a-d0a40b774bed@unboiled.info \
    --to=monk@unboiled.info \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).