From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.2 Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by inbox.vuxu.org (OpenSMTPD) with SMTP id 83904b19 for ; Wed, 29 Jan 2020 11:59:14 +0000 (UTC) Received: (qmail 25650 invoked by uid 550); 29 Jan 2020 11:59:13 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 25632 invoked from network); 29 Jan 2020 11:59:13 -0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=soeren-tempel.net; h=date :to:subject:from:references:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=opensmtpd; bh=EMYhwDj SriiAkLf7fOI9FIxtrio=; b=Ok9kFh6LT/FiHl4Vy3+F8qOEZGkr0yty0KNZy+s ZFEY6w1wZuIJ3v8GPNO9dqu607u4NkQjWHu8I+O5pHwRgaYVdlN56XJzjR8lalF7 H/AlbrXyVtezlcSPFrf2ZYcuy9cXSmWrwzQlb1ufrLJKpE4R1lN8cQzVEY7uJM2b 3xg4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=soeren-tempel.net; h=date:to :subject:from:references:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=opensmtpd; b=x 69BZkkVvn+CIVxTQddG0x8xozJdB4h7yAHkwBh3RffGuSKaGp3rGWZLnsxALqP/f e5zD9t0XXk0NzyxgacdBKAh15irnS2dmJqBrMuUGD9LwMsVHfVCl8rReISUWkLuW qGh/HzKRXi4DzSCNn0Ln0sM4GfZ/8hF3vgE8mbkFt0= Date: Wed, 29 Jan 2020 12:59:00 +0100 To: musl@lists.openwall.com From: =?UTF-8?Q?S=C3=B6ren?= Tempel References: <20200129112007.17575-1-soeren+git@soeren-tempel.net> In-Reply-To: <20200129112007.17575-1-soeren+git@soeren-tempel.net> Message-Id: <2NSST1D2CU3ZF.2X6OJSUS9Q20S@8pit.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [musl] [PATCH v2] cuserid: support invocation with a NULL pointer argument Sorry, forgot to confirm my list subscription before sending the first version of this patch. Just wanted to reply to a comment on the previous version: On Tue, 28 Jan 2020, Rich Felker wrote: > I'm not sure whether to adopt this or not, but thanks for posting on > the list for discussion. In any case it's something we should try to > get fixed in apps that are using it, since this is no longer portable > usage and is gratuitously thread-unsafe. =46rom my personal Alpine Linux packaging perspective: I would prefer either removing the function entirely or supporting the invocation with a NULL pointer argument. Currently, apps using this with a NULL pointer (e.g. cdparanoia) will crash at runtime which makes it more difficult to identify them. If the function would be removed entirely we would be able to detect, during compilation, which apps use it and patch them accordingly. Cheers, S=C3=B6ren