Re: additional patches for musl

["A. Wilcox" <awilfox@adelielinux.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1442 bytes --]

On 12/15/18 18:01, сергей волковичь wrote:
> cabulertion.
> i finded additional patches for implementing some missing musl features.
> 
> 
> -- реклама -----------------------------------------------------------
> Поторопись зарегистрировать самый короткий почтовый адрес @i.ua
> https://mail.i.ua/reg - и получи 1Gb для хранения писем
> 

Hi there.

First of all, welcome and thank you for sending your patches.

I think the canonicalize_file_name and nftw stuff may be okay, though it
does add some bloat.  The qsort_r code may be as well.  These should be
looked at by the musl maintainers themselves to determine suitability
and issues.  (I know the nftw stuff would be useful for a few packages,
myself.)

The utmpx patch should probably be merged.

The printf stuff is LGPL licensed while musl is MIT.  That won't be
workable because the licenses are incompatible.

The strndupa patch does not give an alternative for non-GNU C compilers
and it seems rather arbitrary and gratuitous.  It is better to make the
software more portable than add this, IMO.

The glob and regex macros are going to break code and those are a firm
NAK from me, though I don't know how others feel about them.

Hope this helps.

Best,
--arw
-- 
A. Wilcox (awilfox)
Project Lead, Adélie Linux
https://www.adelielinux.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]