From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/1613 Path: news.gmane.org!not-for-mail From: idunham@lavabit.com Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 1/3] makefile: add silent rules Date: Thu, 16 Aug 2012 19:03:21 -0400 (EDT) Message-ID: <30247.132.241.65.36.1345158201.squirrel@lavabit.com> References: <1345133887-4041-1-git-send-email-lu_zero@gentoo.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1345158216 24370 80.91.229.3 (16 Aug 2012 23:03:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Aug 2012 23:03:36 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-1614-gllmg-musl=m.gmane.org@lists.openwall.com Fri Aug 17 01:03:36 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1T296F-0000ZQ-Gx for gllmg-musl@plane.gmane.org; Fri, 17 Aug 2012 01:03:35 +0200 Original-Received: (qmail 24163 invoked by uid 550); 16 Aug 2012 23:03:34 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 24147 invoked from network); 16 Aug 2012 23:03:33 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lavabit; d=lavabit.com; b=zyoSt3PQ6hQba2+K5bnvMeQMK2cBCbX6N4vnBKMSL5v4oescgO68PLUqqoUJZ+7cd7XDx7vWroWHQDZSz3de9tGtcdmHKl5dAFSkoYHQo+AMM/TbWAvQM6BWHADsKI+80gfmdurLkgaOSBQsMEylHicNjTx8JX4a6Y59bPoO/R0=; h=Message-ID:In-Reply-To:References:Date:Subject:From:To:User-Agent:MIME-Version:Content-Type:Content-Transfer-Encoding; In-Reply-To: <1345133887-4041-1-git-send-email-lu_zero@gentoo.org> User-Agent: SquirrelMail/1.4.13 Xref: news.gmane.org gmane.linux.lib.musl.general:1613 > make V=0 to enable them > --- Remind me what the _benefit_ is? I remember there were several advantages to standard full output, so the verdict was that *if* they're added, they get disabled by default. While this patch does respect that, I'd like to know whether there's a better reason for the added ugliness than "Some folks don't like to see what's happening"... Also, I note that you're also making a couple other changes: RM, LN, and INSTALL... Last time, Rich said he didn't see a reason to use $(RM), since rm is POSIX. Same can be said of ln/$(LN). install appears (per man 1p) to not be POSIX, but is fairly widespread. I can see this helping with the occasional broken version of install. Patch 3/3 is the most valuable part of the series, I think. I can see merging that, and patch 2/3 is trivial. > +LN = ln -sf > ALL_INCLUDES = $(sort $(wildcard include/*.h include/*/*.h) $(GENH)) > +V ?= 1 > + > +ifeq ($(strip $(V)), 0) > +Q = @ > +ECHO = printf "$(1)\t%s\n" $(2) > +BRIEF = CC AS AR LD HOSTCC SH LN > +SILENT = DEPCC RM RANLIB > +MSG = $@ > +M = @$(call ECHO,$(TAG),$@); > +$(foreach VAR,$(BRIEF), \ > + $(eval override $(VAR) = @$$(call ECHO,$(VAR),$$(MSG)); $($(VAR)))) > +$(foreach VAR,$(SILENT),$(eval override $(VAR) = @$($(VAR)))) > +$(eval INSTALL = @$(call ECHO,INSTALL,$$(^:$(SRC_PATH)/%=%)); $(INSTALL)) > +endif > -include config.mak Umm.... Is this an accident? > clean: > - rm -f crt/*.o > - rm -f $(OBJS) > - rm -f $(LOBJS) > - rm -f $(ALL_LIBS) lib/*.[ao] lib/*.so > - rm -f $(ALL_TOOLS) > - rm -f $(GENH) > - rm -f include/bits > + $(RM) crt/*.o > + $(RM) $(OBJS) > + $(RM) $(LOBJS) > + $(RM) $(ALL_LIBS) lib/*.[ao] lib/*.so > + $(RM) $(ALL_TOOLS) > + $(RM) $(GENH) > + $(RM) include/bits Axe this part (see above) > distclean: clean > - rm -f config.mak > + $(RM) config.mak > - ln -sf $(libdir)/libc.so $@ || true > + $(LN) $(libdir)/libc.so $@ || true See above. > $(DESTDIR)$(syslibdir): > - install -d -m 755 $(DESTDIR)$(syslibdir) > + $(INSTALL) -d -m 755 $(DESTDIR)$(syslibdir)