From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 22095 invoked from network); 25 Jun 2020 15:58:59 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 25 Jun 2020 15:58:59 -0000 Received: (qmail 18024 invoked by uid 550); 25 Jun 2020 15:58:57 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 18000 invoked from network); 25 Jun 2020 15:58:56 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cv5la2Ufx/QqAtc4ANey5SxexMzM85AzD4+kF0Hftf0=; b=vV4dM3qQTbOGtSm0mq7Ma2zrm2nD6fGYY4FF+ZgkFhwaTwFJQmjR7yKp00Kzi6Tzuo F0iOjJRVRJnixQPZ0b1psb/8GZlwtpPk1LIuxKruh02Fjl/4Xm29aBB09CA24RcWSMx6 /f5K9ojKg2fqeuv6dcv7LS+QSXJgLSduQ5okcErBfd/b/mergiaTNY0KJds4RUhtr9nU Cov8M8ZdXvnlE93HxESnTlsRwEtbKp30DiD2ScLgZTvc3mLEEkGQxVBHPEg0qSO8NLWq gCLshQuBmdL/nePv60qqOruPUhKlvA8TluQyWdyzvAKCDu3qXq0AJOgbAVwBy4jVCNcq htdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=cv5la2Ufx/QqAtc4ANey5SxexMzM85AzD4+kF0Hftf0=; b=syBpji0FE2pWqJAAZIKRkRJczVrorRgpdKOlozQF3kX8BMxZEz/07MkTfjLjqohSYT A6Kwa1ZmvkraqjUE2EAee6DlItgM31yglt+J6bpH/MfFOknB4P7oKAYaz5b0MbbkoSbT NoH8LhzNT4bqb4hVBYWAS5u7CtGHhKNVjYVzQakvhXjA0psa/040dJB91sMoQw2kwH47 L7ZSzov76YHmYIR8Jf2HP8K3SVWGL+A6LH8GwSmfkAwAeEGEZPAMz4xWhhHEEyPkE21b VEbQ2/EF7b2F/AYlRMoKDTdtRnuDKLVIQ5ujEhUp1uQUYJYVAiXabPo3VvSe+N4IccVp PH6w== X-Gm-Message-State: AOAM530tsywp88wYP21UEz6kCY10vsYmTgfINnowIWWxwnio3OG4xUps DdVDhpLXg0FDSpsSeZh3RKc= X-Google-Smtp-Source: ABdhPJwVcSiV4GWRjE9zFOXJmwy2dvoN1HR4vtUv6FGTmqpbXdsCc2VPQC/x98NBb6RcPFxGjbP2EA== X-Received: by 2002:a63:4c48:: with SMTP id m8mr27241770pgl.290.1593100723952; Thu, 25 Jun 2020 08:58:43 -0700 (PDT) To: musl@lists.openwall.com, Daniel Santos Cc: daniel@gsat.us References: <20200624232008.4093-1-daniel.santos@pobox.com> From: Khem Raj Autocrypt: addr=raj.khem@gmail.com; keydata= mQGiBEqXaJERBACUvFofpD3FsxD9675wcPv+rzguIfsRWilrrpSZ61JHjLHwkUnmDLpLSdfv Zw2ZDXeaQbGU2thctxXTyYf6N1fY6P5Tww6mWKInuGU3yAv8Mg5p+Xd8itwOoVR41DOBkftV miO2G7FtXsnqonB6F43a2yvc+h9OwPRVxAFss5mSmwCglSXPWndN1Ka4M/hzt7g+FmeyEssD /1V/G8lLeAS9gQCNjS7jch+uHMFJuWgHzMXdw99e1ywlIkvXN77NPkW+FLVxKxNAHyWZZ3wO 4BQ9/GVR2y0s/rrF1lQSIcfnUmzZrh/Bh0b1wVOSLhl0Vx4MI0/MbdL3xx17JAWy+s67evuK ER4Y8ycTq3gbIGJtVrIJjWPCzWF8BACAA2u52uDmJ2pS8SIhEW0jMK/zYQ5Od9l9fM6BmS6Q jnIlzzcuMvRdZn2IrnuE/YoC8yyzBK3mN+MVc2jWN9rfSg6ml7r14Zjem9Ee0O5Ca7Jg3ZvN 6g3vSlrRJqKgsnq3vdatDF+5rd0NJ7ZKUy6x2i1Pavgtv3qaAgPGa1qQdLQdS2hlbSBSYWog PHJhai5raGVtQGdtYWlsLmNvbT6IYAQTEQoAIAIbAwYLCQgHAwIEFQIIAwQWAgMBAh4BAheA BQJTBC0aAAoJELsFM1WRnTMUul4An282FaN7oYXM2A8JzQt1ZWeUTlJZAJ0eOgup2Eqxx6gZ FOQE7EkRmOb6iLkEDQRKl2iREBAAjjbVQ55RAouAe0l0nPsKkWdtMuUHwBdLBkpF3rGM/f0u DlPaQzYGLjKT7xDoyRh8x2tFwWvOfiqrZFArxX8e4fsACmJdL0kahTbxC/8SmSWVHXi10JUX 2fmZ5ufzlXAnl0ivXkWnrUfLX9DdNwL6DR4DeFK9qBFqtHmK5TQXMu87G+MJwgNJIwCKQX4i I9YJILMuqInVwaxg5/ALdKfE3QPmtadnKb/cuUm4gICdaJeyQfI6qdYLcSuyBWCbAEMM1wmh RAhw5RgzMRRIquZlxPt7lZkXXjals7M6juh87VGRoIJwYoQi97Q1ZHzPBo3AlMPe3haNihkd 6D3lwvdB4pmjYG4I6bHCgtEhEss3hHvsBaqV9jV1dMUSs95ZxQtT9qtkOxydHgOlwRX3CG+r 584J/s4vWm+iPQtLvDY1u4UFwOLjCOFe709BcLJdPR2GQiOPoyZF7lVY8nu/dtTrAEuiZFk4 HD7afUlcr/IKwPWID1V9kRLoDlzdbNuoUy/XfVErK8wcoiGowerEMed4ajNoKxCxBweIkjxq KMt8CKgp30n9UxljglEcgf+/UumwSHxqZcCPVbWXtdhy/hwMk27shOdUvaiynep8OsVGqAzS seL4qZIJ5XzCcyV4KJCmwmdQzt5+ZylcVmeq6R4ob+d8JIDU0ELqdwxwIDiTj0cAAwUP/inN 3/r8IFDms4g5xafPrCw31o2jIYahkIfN0WVPWI5K/hFCo2PczPStzDcTsZx7mN2qwpGOe3Lz 9/0krZeksrz1ZIHNi5LTasuzXyFJbO05Y+eiHgV1rV7VVEipOrpV1496w112Y/0SZ/FhOfEm EA1TeDejy2sZiTOUW4gyzewbHMpE07d27F2qM2NfMMhKQCcvzr+N0VJmAOeATEivxPUHn+Dp X/NniBWOcWv++wHlxv0Xr63gsRKSt62eFKGjgF50hHD5lM31ziqycc42sbgcqAZ+rYFlb9k0 3JcKyq1XdVUSm+xcC2DMSstTI6iqFMGo6FnEO+gyE5VdceajbuZ1GOmJXJUCyYIdGuvCyIoK jTE9lcIYSEEDZQej5xdiGk9eUz0MPmZEUwSR/nLmmwjHDJi0prVvs9xqe5bvS3ddPAqepvZ5 UrisgtWD+TDI8ktkt5VLh3XsG9FuXUVAaahOvFMGiZtsioDXTorL4AfMeuA9f+yLwrCVQO3x mH/WA0Tgf/5gYB3t9KoHPjLBNruVOuQbAjubi0pvRAOUcMdBfmPofksK4uWS1zGtPWS7Uu1c suq7Hnb7vszlFYdbzeqjY81LSyxA0kcpgJxdLv9o7UuCEnHDZLPbHdQ83PmyyBKSI31AKe7R XlQNlB5grwH9o6uNtPbV7q/uRqmKq5EiiEkEGBECAAkFAkqXaJECGwwACgkQuwUzVZGdMxR1 VACcCkdaO3rb8/gRprldmAH6eR49eo4AnjD3h3aTwv/1bl+BAz1twmZmz8ul Message-ID: <39be4d66-963c-4e06-e685-37a8396d10c3@gmail.com> Date: Thu, 25 Jun 2020 08:58:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200624232008.4093-1-daniel.santos@pobox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [musl] [PATCH] Fix signed compare warning On 6/24/20 4:20 PM, Daniel Santos wrote: > Signed-off-by: Daniel Santos > --- > src/thread/__timedwait.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/thread/__timedwait.c b/src/thread/__timedwait.c > index 666093be..9829b93e 100644 > --- a/src/thread/__timedwait.c > +++ b/src/thread/__timedwait.c > @@ -38,7 +38,7 @@ int __timedwait_cp(volatile int *addr, int val, > if (priv) priv = FUTEX_PRIVATE; > > if (at) { > - if (at->tv_nsec >= 1000000000UL) return EINVAL; > + if ((unsigned long)at->tv_nsec >= 1000000000UL) return EINVAL; > if (__clock_gettime(clk, &to)) return EINVAL; > to.tv_sec = at->tv_sec - to.tv_sec; > if ((to.tv_nsec = at->tv_nsec - to.tv_nsec) < 0) { > may be use < 0 || >= 1000000000L and avoid the cast. there is a similar issue in src/thread/pthread_cond_timedwait.c as well