mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Dj Padzensky <djpadz@padz.net>
To: musl@lists.openwall.com
Subject: [musl] %l missing in strftime()
Date: Thu, 29 Oct 2020 10:02:59 -0400	[thread overview]
Message-ID: <3D3DD419-84C6-437A-930A-EAD6777C0130@padz.net> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 858 bytes --]


Hi there-

Long time fan, first time caller…  :-)

I noticed that, despite the man page’s claim, %l (that’s ell) is not implemented in strftime().  This patch should do the job.

diff --git a/src/time/strftime.c b/src/time/strftime.c
index cc53d536..78f12ae0 100644
--- a/src/time/strftime.c
+++ b/src/time/strftime.c
@@ -104,6 +104,12 @@ const char *__strftime_fmt_1(char (*s)[100], size_t *l, int f, const struct tm *
                val = tm->tm_yday+1;
                width = 3;
                goto number;
+       case 'l':
+               def_pad = '_';
+               val = tm->tm_hour;
+               if (!val) val = 12;
+               else if (val > 12) val -= 12;
+               goto number;
        case 'm':
                val = tm->tm_mon+1;
                goto number;


Keep up the great work!

—Dj

[-- Attachment #1.2: Type: text/html, Size: 3772 bytes --]

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4372 bytes --]

             reply	other threads:[~2020-10-29 14:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 14:02 Dj Padzensky [this message]
2020-10-29 14:45 ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D3DD419-84C6-437A-930A-EAD6777C0130@padz.net \
    --to=djpadz@padz.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).