From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 7977 invoked from network); 18 Jan 2021 04:12:02 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 18 Jan 2021 04:12:02 -0000 Received: (qmail 7931 invoked by uid 550); 18 Jan 2021 04:11:58 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 7910 invoked from network); 18 Jan 2021 04:11:57 -0000 X-Virus-Scanned: Debian amavisd-new at disroot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1610943105; bh=HvYcBkntPs3O6k8PAdqlaxmDaNMZE4ybmNbG4VoU810=; h=Subject:From:To:Reply-To:References:Date:In-Reply-To; b=i1axP19ZWdkabuFtcF8AhoDI3ELYgfbC4rKOPWi0y+oq9O3ps/Q8H/QWffSFx+6aa werMfHlHUdyggfNl5zI/7artPI1m1uXut+iH1MCAWWMuKfhWIEJtPmh6gAVeapf1ke ouVEnOiJ4FW04EgPQsMmxeX18fIOnEulpuVZ0+T3TyY6jSXkoucmeokAJses/MJvKL r3hEETA6IKvtNyopa5puyIinSK4vXWy6EIdvN6C5SmWrT/dQUz09T65venUImCS8f0 GEFRE0Yh2i0UOBEDHyZ2fsBrNIF8CK1EvOGW7iYcpNS9HrFHLNlqjeibjGR7TCyoMM be/INZH3pZ2AA== From: =?UTF-8?Q?=c3=89rico_Nogueira?= To: musl@lists.openwall.com References: Message-ID: <3d59f0d9-cfd0-049c-b90e-8f118f54f5fe@disroot.org> Date: Mon, 18 Jan 2021 01:11:40 -0300 Mime-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [musl] Some pending changes/patches Sorry for the noise, I forgot one patch: - use SYS_openat instead of SYS_open in open(2) to avoid spurious fcntl syscalls: https://inbox.vuxu.org/musl/20201229225518.3677-1-ericonr@disroot.org/ All the questions in the patch still apply, so I don't believe it's ready to be merged, but a review would be very helpful - pointers on the matter of the kernel timeline regarding SYS_openat and O_CLOEXEC flag would also be appreciated. And maybe it should be using __syscall_cp for the syscall (I believe this makes a difference for cancellation points)? Cheers Em 17/01/2021 16:42, Érico Nogueira escreveu: > Hi! > > Firstly, congratulations on the new release :) > > Secondly, I have some pending patches that I'd like to ping, plus some > changes that I was asked to post about once the 1.2.2 release had been > made. > > - add cloexec flag to open() in pthread_setname_np: > https://www.openwall.com/lists/musl/2020/12/24/1 > > - (low-priority) add pthread_getname_np: > - my version (needs to be cleaned up for the change in the patch > above): > https://www.openwall.com/lists/musl/2020/12/19/3 > It tries to avoid duplicating the setup for the > /proc/self/task/%d/com path by adding a helper function. > - older version: > https://inbox.vuxu.org/musl/AM0PR07MB442007DDD4FECFF99BB5EBF48BE70@AM0PR07MB4420.eurprd07.prod.outlook.com/ > Lacks cloexec flag when opening file. > > - (low priority) implement gethostid() beyond a stub: > https://inbox.vuxu.org/musl/20200804224230.27774-1-ericonr@disroot.org/ > > - fix type for __libc_start_main. In crt1.c and rcrt1.c, it is: > > int __libc_start_main(int (*)(), int, char **, > void (*)(), void(*)(), void(*)()); > > but in __libc_start_main.c, it is > > int __libc_start_main(int (*main)(int,char **,char **), int argc, char **argv) > > as far as I can tell the fix is simple and the signature mismatch isn't > an issue. Since I don't know the context for the mismatch and therefore > wouldn't be able to write an appropriate commit message, I refrained > from sending a patch for it. > > Happy new year, > Érico >