From: Luca Barbato <lu_zero@gentoo.org>
To: musl@lists.openwall.com
Subject: Re: Fix warnings when build with clang
Date: Mon, 27 Jun 2016 19:41:49 +0200 [thread overview]
Message-ID: <409e13bc-9e0c-9db6-977b-1a90b18d278e@gentoo.org> (raw)
In-Reply-To: <20160627172159.GH10893@brightrain.aerifal.cx>
On 27/06/16 19:21, Rich Felker wrote:
> On Mon, Jun 27, 2016 at 10:01:52AM -0700, weimingz@codeaurora.org wrote:
>> On 2016-06-25 02:37, Szabolcs Nagy wrote:
>>> * Zhao, Weiming <weimingz@codeaurora.org> [2016-06-24 17:18:23 -0700]:
>>>> Clang gives warnings about the missing parentheses for bitwise ops.
>>>>
>>>> It's not functional but just code readability.
>>>>
>>>> musl-m3/include/endian.h:32:25: warning: '&' within '|'
>>>> [-Wbitwise-op-parentheses]
>>>> return __x>>24 | __x>>8&0xff00 | __x<<8&0xff0000 | __x<<24;
>>>> ~ ~~~~~~^~~~~~~
>>>
>>> if clang warns about system headers that's a clang bug.
>>
>> The endian.h is a musl file.
>
> Right, which is why it's a system header.
I'm not sure there is a simple way to know what's a system header and
what is not, beside keeping a list.
And even in that case I'm not so sure the compiler should hide warnings
(no matter how fringe this actual warning is).
lu
next prev parent reply other threads:[~2016-06-27 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-25 0:18 Zhao, Weiming
2016-06-25 9:37 ` Szabolcs Nagy
2016-06-27 17:01 ` weimingz
2016-06-27 17:21 ` Rich Felker
2016-06-27 17:30 ` Zhao, Weiming
2016-06-27 17:41 ` Luca Barbato [this message]
2016-06-27 17:55 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=409e13bc-9e0c-9db6-977b-1a90b18d278e@gentoo.org \
--to=lu_zero@gentoo.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).