From: Dmitry Golovin <dima@golovin.in>
To: musl@lists.openwall.com
Subject: Proper warning silencing patch for Clang
Date: Fri, 09 Jun 2017 17:10:47 +0300 [thread overview]
Message-ID: <4172411497017447@web59g.yandex.ru> (raw)
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
Hi!
This time the patch doesn't break anything. Check for supported optimizations is performed using "-Werror=ignored-optimization-argument" (clang specific) and also "-Qunused-arguments" is added to silence unused argument warnings (ignoring unused arguments is default behavior for GCC, but not for Clang).
The patch is attached.
Regards,
Dmitry
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-add-proper-check-for-clang-supported-optimization-an.patch --]
[-- Type: text/x-diff; name="0001-add-proper-check-for-clang-supported-optimization-an.patch", Size: 1245 bytes --]
From c37efc541b12d8e216b7a425808e4c24c48f9213 Mon Sep 17 00:00:00 2001
From: Dmitry Golovin <dima@golovin.in>
Date: Fri, 9 Jun 2017 16:41:53 +0300
Subject: [PATCH] add proper check for clang supported optimization and stop
complaining about unused arguements
---
configure | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/configure b/configure
index c2db298..539c9fc 100755
--- a/configure
+++ b/configure
@@ -249,6 +249,7 @@ fi
#
tryflag CFLAGS_TRY -Werror=unknown-warning-option
tryflag CFLAGS_TRY -Werror=unused-command-line-argument
+tryflag CFLAGS_TRY -Werror=ignored-optimization-argument
tryldflag LDFLAGS_TRY -Werror=unknown-warning-option
tryldflag LDFLAGS_TRY -Werror=unused-command-line-argument
@@ -504,6 +505,13 @@ tryflag CFLAGS_AUTO -Werror=implicit-int
tryflag CFLAGS_AUTO -Werror=pointer-sign
tryflag CFLAGS_AUTO -Werror=pointer-arith
+#
+# GCC ignores unused arguements by default, but Clang needs this extra
+# parameter to stop printing warnings about LDFLAGS passed during
+# compiling stage and CFLAGS passed during linking stage.
+#
+tryflag CFLAGS_AUTO -Qunused-arguments
+
if test "x$warnings" = xyes ; then
tryflag CFLAGS_AUTO -Wall
tryflag CFLAGS_AUTO -Wno-parentheses
--
2.13.0
next reply other threads:[~2017-06-09 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 14:10 Dmitry Golovin [this message]
2017-06-23 19:46 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4172411497017447@web59g.yandex.ru \
--to=dima@golovin.in \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).