From: Alexey Izbyshev <izbyshev@ispras.ru>
To: musl@lists.openwall.com
Cc: Rich Felker <dalias@aerifal.cx>, Rich Felker <dalias@libc.org>
Subject: Re: Bug in gets function?
Date: Thu, 14 Feb 2019 00:39:07 +0300 [thread overview]
Message-ID: <419e95bb3a69fa0990e56996e198355f@ispras.ru> (raw)
In-Reply-To: <20190212163027.GK23599@brightrain.aerifal.cx>
On 2019-02-12 19:30, Rich Felker wrote:
> Here's an alternate proposal via direct implementation:
>
> char *gets(char *s)
> {
> size_t i=0;
> int c;
> FLOCK(stdin);
> while ((c=getc_unlocked(stdin)) != EOF && c != '\n') s[i++] = c;
> s[i] = 0;
> if (c != '\n' && !feof(stdin)) s = 0;
> FUNLOCK(stdin);
> return s;
> }
>
> Does this look ok? Of course it's slow compared to a fgets-like
> operation on the buffer, but gets is not a usable interface and I
> don't see any reason to care whether it's fast.
>
gets() must also return NULL if EOF is reached and no bytes were read.
Alexey
next prev parent reply other threads:[~2019-02-13 21:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 2:55 Keyhan Vakil
2019-02-12 3:48 ` Rich Felker
2019-02-12 3:51 ` Rich Felker
2019-02-12 14:41 ` James Larrowe
2019-02-12 14:55 ` Ponnuvel Palaniyappan
2019-02-12 16:30 ` Rich Felker
2019-02-13 21:39 ` Alexey Izbyshev [this message]
2019-02-13 22:13 ` Rich Felker
2019-02-13 23:19 ` Alexey Izbyshev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=419e95bb3a69fa0990e56996e198355f@ispras.ru \
--to=izbyshev@ispras.ru \
--cc=dalias@aerifal.cx \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).