From: Shiz <hi@shiz.me>
To: musl@lists.openwall.com
Subject: Re: [PATCH] netinet/tcp: Add TCPOPT, TCPOLEN constants
Date: Sat, 2 Jan 2016 20:15:16 +0100 [thread overview]
Message-ID: <42734146-83D1-41CA-9389-5D14284BD2A2@shiz.me> (raw)
In-Reply-To: <CAOji9TAkBkxq=a2ejrB2yiY6cYG9dU6Gd24d6vH28mz2cpqo+A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
> On 02 Jan 2016, at 03:18, Kylie McClain <somasissounds@gmail.com> wrote:
>
> I've attached it since I don't trust gmail to not mess up patch
> formatting.
This seems off:
>+#ifdef defined(_BSD_SOURCE)
I think you either want #ifdef _BSD_SOURCE or #if defined(_BSD_SOURCE) here.
- Shiz
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-01-02 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-02 2:18 Kylie McClain
2016-01-02 19:15 ` Shiz [this message]
2016-01-03 4:24 ` Rich Felker
2016-01-03 6:18 ` Kylie McClain
2016-01-04 2:48 Kylie McClain
2016-01-17 22:37 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42734146-83D1-41CA-9389-5D14284BD2A2@shiz.me \
--to=hi@shiz.me \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).