From: Bruno Haible <bruno@clisp.org>
To: Rich Felker <dalias@aerifal.cx>
Cc: Assaf Gordon <assafgordon@gmail.com>,
bug-gnulib@gnu.org, musl@lists.openwall.com
Subject: Re: localename: add support for musl libc
Date: Sun, 25 Feb 2018 22:19:06 +0100 [thread overview]
Message-ID: <4622267.x626kDHS96@omega> (raw)
In-Reply-To: <20180225181904.GN1436@brightrain.aerifal.cx>
Hi Rich,
> Really use of NL_LOCALE_NAME should always be preferred if it's
> available, since it's a clean public interface for the functionality
> desired rather than a hack poking at implementation internals. But if
> you really like poking at internals for other implementations ...
In a perfect world, what you say would make sense.
However, not all libc versions that define _NL_LOCALE_NAME also have
a _NL_LOCALE_NAME that *works* [1]. It's not that I "really like poking
at internals". It's that I want my code to actually work.
> The comment /* musl */ above is wrong and should not have been added.
How can you judge that a comment in gnulib code is adequate, when you
are not familiar with the way gnulib is developed?
The comment /* musl */ says two things:
- If a developer makes changes to these piece of code, they should
test in on a system with musl libc.
- If a developer sees that this code is being compiled/executed on
a system without musl libc, they should review the #if chain, to
make sure no mistake was introduced in #ifs.
Now back to my comment that you haven't addressed, regarding lack of
__MUSL__:
If someone else
creates a platform that shares the same superficial characteristics
(runs on Linux, has <langinfo.h> and NL_LOCALE_NAME) but behaves
differently, we will accidentally run into the code intended for musl
on that platform. Whereas the fallback code (return "" in this case)
would be safer: it would make the unit test fail, but it would not
lead to a compilation error or to a code dump.
And if that platform does not have an identifiying macro either, we
really got a problem how to distinguish the two.
Bruno
[1] https://sourceware.org/bugzilla/show_bug.cgi?id=10968
next prev parent reply other threads:[~2018-02-25 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6726776.syxiYx1ubZ@omega>
[not found] ` <20180225075444.GB1188@tomato>
[not found] ` <7452235.CQINynMRMO@omega>
2018-02-25 18:19 ` Rich Felker
2018-02-25 21:19 ` Bruno Haible [this message]
2018-02-25 23:40 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4622267.x626kDHS96@omega \
--to=bruno@clisp.org \
--cc=assafgordon@gmail.com \
--cc=bug-gnulib@gnu.org \
--cc=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).