From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/128 Path: news.gmane.org!not-for-mail From: =?UTF-8?B?THVrYSBNYXLEjWV0acSH?= Newsgroups: gmane.linux.lib.musl.general Subject: Re: cluts review Date: Wed, 13 Jul 2011 14:02:44 +0200 Message-ID: <4E1D8964.3020502@gmail.com> References: <20110713110723.GA22153@openwall.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1310558668 23617 80.91.229.12 (13 Jul 2011 12:04:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2011 12:04:28 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-212-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jul 13 14:04:25 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1QgyAy-0004oR-8b for gllmg-musl@lo.gmane.org; Wed, 13 Jul 2011 14:04:24 +0200 Original-Received: (qmail 24058 invoked by uid 550); 13 Jul 2011 12:04:22 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 24038 invoked from network); 13 Jul 2011 12:04:22 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=UKzEQNE2USQDWfyvpVaWk/fVz6cb7IdfkLR42r6DSus=; b=RtxWfRiQqFbfNBXJTBL0igTTCITOUjMZqvJb5kKIASw9r+vkdDieLK7NjzaOaZ8X3j +5zQcWlLYLeYxkTG7VthZmPqJcCUHwMV8Zy8ikikOF45G8PLPUU1u3rbbJ3uqSomZSwP lxxHo5Cj0r5aL8LjWCHx/q3OV1//2aLsoNwJc= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110626 Icedove/3.1.11 In-Reply-To: <20110713110723.GA22153@openwall.com> Xref: news.gmane.org gmane.linux.lib.musl.general:128 Archived-At: On 07/13/2011 01:07 PM, Solar Designer wrote [...] Hmm, hope you won't mind me saying: Diff output for multiple files replacing 1-2 non-subsequent lines is not very readable. Anyway, I'll add _POSIX_SOURCE for sigaction and replace SA_NODEFER with 0 (I'm sure it served its purpose *somewhere* :-/). Not sure why _BSD_SOURCE is needed for alphasort, but I see from the man it is (I usually look up functions from SUSv4), so I'll add that too. Instead of for PATH_MAX, will limits.h do (that's what i usually include)? > As it is, this patch is a hack. I think that extensive cleanups to the > code being patched are needed. As I've announced, alloc.c is going to be rewritten: As Rich suggested to me, it'll use arrays instead of lists which will speed up things and make them prettier.. actually I think it's in alloc.c's TODO. String.c will also be rewritten, because, as I've said, it's impractical to write so much code for a few tests (not sure yet how exactly). If there are any other critiques, I would like to hear them. > I have other observations as well (such as from actually running the > tests), which I hope to post separately. Ok. I only hope it's understood that I've made the tests report failures alone. It would serve no purpose to output success messages (eg. numeric.c would report a *lot* of things). If that's not what you meant, shoot, I'm listening. Thanks Luka.