From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/144 Path: news.gmane.org!not-for-mail From: =?UTF-8?B?THVrYSBNYXLEjWV0acSH?= Newsgroups: gmane.linux.lib.musl.general Subject: Re: cluts review Date: Wed, 13 Jul 2011 18:25:51 +0200 Message-ID: <4E1DC70F.7000501@gmail.com> References: <20110713110723.GA22153@openwall.com> <20110713133838.GA16618@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1310574456 32110 80.91.229.12 (13 Jul 2011 16:27:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2011 16:27:36 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-228-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jul 13 18:27:32 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Qh2Ha-0000aQ-7v for gllmg-musl@lo.gmane.org; Wed, 13 Jul 2011 18:27:30 +0200 Original-Received: (qmail 3521 invoked by uid 550); 13 Jul 2011 16:27:29 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 3513 invoked from network); 13 Jul 2011 16:27:29 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=UASiFHLi/Zaq5z4hzth+nIal0UssHokOvTZ4kt98lAA=; b=slEB6i8OVGMtkaRbcTyHWIakbKmkCu1LD1DZAFjriHa1vsOlc+GaVKL8fTTcxgLxNF UHjpcnahI9Mjt/sbBwxFmlgqOlTW5YTqWzna1nW7XmblR8ydFkMmv+AkgFfmM2fx63KU apgukdmhVwE3fTt8C2JIxoKiK3gbpuUBB4kKU= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110626 Icedove/3.1.11 In-Reply-To: <20110713133838.GA16618@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:144 Archived-At: On 07/13/2011 03:38 PM, Rich Felker wrote: > Since the tests are > testing a POSIX environment, -D_POSIX_C_SOURCE=200809L (or even > -D_XOPEN_SOURCE=700) should be in the CFLAGS. > How about I just put define POSIX_C_SOURCE 200809L everywhere in the header, that should do the trick, right? If I put it as a flag, it might not be clear to someone who just yanks a test collection/source file out of the suite. *shrugs* >> - act.sa_flags = SA_NODEFER; >> + act.sa_flags = 0; > This was being used as part of the longjmp trick. Can you remind me what this does exactly? I can't remember anymore, seemed to me it really was not needed. man says so as to not prevent the signal handler from (paraphrasing:) calling a signal itself. I don't need this, but you probably suggested it for some other reason then. Please do remind me. Thanks. > By the way, there are a lot of warnings about local vars potentially > clobbered by longjmp. Those are worth checking out. I found gcc was > pretty strict about breaking my code in the dynamic linker when I > broke the rules for longjmp... These result from the -02 parameter. -Wall and -Wextra should report nothing. I checked buf.c for clobbering, and corrected what was necessary. There might be some other files where the same is needed, will look into then. > *asprintf is not portable because it's a GNU extension, but it's > trivial to implement it as a wrapper for vsnprintf which is standard. > See the code in musl for an example of how to do it. Oh. That might be why I haven't heard of it. Well, I am using the other one for sreturnf... Thanks Luka.