From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/145 Path: news.gmane.org!not-for-mail From: =?UTF-8?B?THVrYSBNYXLEjWV0acSH?= Newsgroups: gmane.linux.lib.musl.general Subject: Re: cluts review Date: Wed, 13 Jul 2011 18:55:01 +0200 Message-ID: <4E1DCDE5.1040008@gmail.com> References: <20110713110723.GA22153@openwall.com> <4E1D8964.3020502@gmail.com> <20110713160327.GA24660@openwall.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1310576204 10875 80.91.229.12 (13 Jul 2011 16:56:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2011 16:56:44 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-229-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jul 13 18:56:40 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Qh2jn-00073K-UY for gllmg-musl@lo.gmane.org; Wed, 13 Jul 2011 18:56:40 +0200 Original-Received: (qmail 23637 invoked by uid 550); 13 Jul 2011 16:56:39 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 23629 invoked from network); 13 Jul 2011 16:56:39 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=EGvG7oja5z8ZKIWZFm+lY6c/70W9MUH3IMxmaLP+vvQ=; b=T0UwUSxJj5/qUvHFXgn23u3bwBynQPaUCC9W5dlS1KEG+UgSq6Q9aAktBZvtiwUEto PvdO1PmNZ5wcnmF2oI+XcBzjsqTLFpu7y0WaUPM9C3L+wAZysu4hk5bCGc6vbyWizIp0 eorKeItqqjcgoXiU5wUZ4HFmbOQ8Y3DbS1Dsw= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110626 Icedove/3.1.11 In-Reply-To: <20110713160327.GA24660@openwall.com> Xref: news.gmane.org gmane.linux.lib.musl.general:145 Archived-At: On 07/13/2011 06:03 PM, Solar Designer wrote: > Luka, Rich - > > The below is not criticism, but just some feedback on my test run of > cluts earlier today. > > So, with the changes that I described before, I built cluts on a glibc > 2.3.6'ish linux-threads system (yes, pre-NPTL). > [...] > > As to cluts going to sleep, this is probably a bug in alloc.c. If this > file is going to be rewritten, then it might not make sense to chase the > bug down now. But it is useful to re-test the new version with low > RLIMIT_AS as well. Thanks for the tip. > After a while, I killed the alloc thread that consumed the most CPU time. > > (BTW, all of them are just ./cluts in "ps" because cluts.c passes its > own argv[0] to exec. Perhaps it'd be nicer to fix that.) Wasn't aware of this. Will fix. > The 'alloc' test collection crashed! > Executing 'buf' test collection... > > I got lots of errors from "numeric" - I didn't bother recording most. > The above are just a few of them. In my opinion, the errors are warranted. But I asked Rich for review on that one. In fact, the collection blocks a lot of error messages. Each string that gets passed to multiple functions is printed only with the first function that fails running with it (in your, strtoumax appears a lot of times, because that's the first function that gets executed with each string). The huge long long integer printout is I guess what makes it look as if there are more messages than there are. Other than that, it's probably the implementations. If it still turns out to be a test data issue, let me know. > The 'numeric' test collection failed 16384 test(s). Hmm, is it an up-to-date version of cluts.c? The number is overblown. > Executing 'string' test collection... > The 'string' test collection passed. String.c always does (it still returns 0 no matter what) ;-P > Test collections passed: 1/4 > > This is the known issue with number of failed test collections, right? > Should have been 2, I guess. This is the number of passed collections. I don't know why it says "out of four" here, if you still have the buf.c-less version :-/ > Thanks, > > Alexander Thank you for the review. I'll offer my responses to feedback in form of commits :-) Luka.